BUG: Fix unpickling of string dtypes of legacy pandas versions #61770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam3851
changed the title
jorisvandenbossche
added
Bug
Strings
jorisvandenbossche
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
@Liam3851 thanks a lot for the bug report and the fix!
Looks perfect, and thanks for adding legacy data (we should probably also add some data for 2.0-2.2 ..).
Can you add a note in the doc/source/whatsnew/v2.3.1.rst file? Because we will want to backport this fix
|
Thanks very much for the review @jorisvandenbossche, I've added pickles for 2.0-2.2 as extra checks and a whatsnew entry. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 7, 2025
… legacy pandas versions
| @@ -59,6 +59,7 @@ Bug fixes | |||
| - Bug in :meth:`.DataFrameGroupBy.min`, :meth:`.DataFrameGroupBy.max`, :meth:`.Resampler.min`, :meth:`.Resampler.max` where all NA values of string dtype would return float instead of string dtype (:issue:`60810`) | |||
| - Bug in :meth:`DataFrame.sum` with ``axis=1``, :meth:`.DataFrameGroupBy.sum` or :meth:`.SeriesGroupBy.sum` with ``skipna=True``, and :meth:`.Resampler.sum` with all NA values of :class:`StringDtype` resulted in ``0`` instead of the empty string ``""`` (:issue:`60229`) | |||
| - Fixed bug in :meth:`DataFrame.explode` and :meth:`Series.explode` where methods would fail with ``dtype="str"`` (:issue:`61623`) | |||
| - Fixed bug in unpickling objects pickled in pandas versions pre-2.3.0 that used :class:`StringDtype` (:issue:`61763`). | |||
There was a problem hiding this comment.
Thanks @Liam3851 for the PR.
For future reference, by convention the trailing period is normally excluded. But no need to do anything as a follow up as will probably be changed when the release notes are tidied just prior to release.
jorisvandenbossche
added a commit
that referenced
this pull request
Jul 7, 2025
…pes of legacy pandas versions) (#61793) Co-authored-by: David Krych <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.3.1.rstfile if fixing a bug or adding a new feature.