DOC: Correct error message in AbstractMethodError for methodtype argument #61827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Jul 11, 2025
|
Thanks @Maaz-319 |
Glad to contribute @mroeschke |
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Aug 19, 2025
…ment (pandas-dev#61827) * DOC: Correct error message in AbstractMethodError for methodtype argument * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an error message in the AbstractMethodError class found in pandas/errors/init.py.
Currently:
raise ValueError(
f"methodtype must be one of {methodtype}, got {types} instead."
)
Here, {methodtype} and {types} are swapped.
This means if you called this error with methodtype="foo", the message would read:
methodtype must be one of foo, got {'method', 'classmethod', 'staticmethod', 'property'} instead.
That’s confusing, because the set of valid types should be listed after “must be one of”, and the invalid value you passed should be listed after “got”.
Corrected:
raise ValueError(
f"methodtype must be one of {types}, got {methodtype} instead."
)
Now, if you called this error with methodtype="foo", the message would read:
methodtype must be one of {'method', 'classmethod', 'staticmethod', 'property'}, got foo instead.
This is clearer and follows standard error message conventions.