BUG: Raise TypeError for mismatched signed/unsigned dtypes in IntervalIndex.from_arrays #62376
Conversation
…lIndex.from_arrays
|
@jbrockmendel please review these changes when you get a chance. |
pandas/core/indexes/interval.py
Outdated
| copy: bool = False, | ||
| dtype: Dtype | None = None, | ||
| ) -> IntervalIndex: | ||
| # Check for mismatched signed/unsigned integer dtypes |
There was a problem hiding this comment.
i think it would make more sense to do this on the IntervalArray.from_arrays method
There was a problem hiding this comment.
Thanks! I will update changes in IntervalArray.from_arrays
|
@jbrockmendel I’ve updated this as per your suggestions. |
pandas/core/arrays/interval.py
Outdated
| ) -> Self: | ||
| # Check for mismatched signed/unsigned integer dtypes | ||
| left_dtype = getattr(left, "dtype", None) | ||
| right_dtype = getattr(right, "dtype", None) |
There was a problem hiding this comment.
i think putting this after the _maybe_convert_platform_interval calls would be more robust. e.g. if one is a list and the other is uint64?
Also is it just int vs uint we care about, or also e.g. int32 vs int64?
There was a problem hiding this comment.
We are checking int vs unit .
There was a problem hiding this comment.
is there a reason not to move this to after the _maybe_convert_platform_interval calls?
There was a problem hiding this comment.
no, i have updated, also added whatsnew note, please let me know if this needs improvement.
pandas/core/arrays/interval.py
Outdated
|
|
||
| # Check for mismatched signed/unsigned integer dtypes | ||
| left_dtype = getattr(left, "dtype", None) | ||
| right_dtype = getattr(right, "dtype", None) |
There was a problem hiding this comment.
the getattr should be unnecessary. the attribute should always be there now that this is moved to after
There was a problem hiding this comment.
thanks, got it. i have updated the code and removed none check for dtype.
This PR adds a check in I
ntervalIndex.from_arraysto raise aTypeErrorwhen integer arrays have mismatched signedness. Includes a unit test to verify the behavior.Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !