Skip to content

Conversation

anthonyspeicher
Copy link
Contributor

@Alvaro-Kothe
Copy link
Member

Thanks for the PR @anthonyspeicher, can you update your branch and remove the files that you modified from pyproject.toml?

pandas/pyproject.toml

Lines 435 to 438 in 179258f

# TODO: Fix B905 (zip-without-explicit-strict) - Remove files below as they're fixed
# For contributors working on this issue:
# After adding strict={True,False} to zip() calls in a file,
# remove its line from this section

@anthonyspeicher
Copy link
Contributor Author

Of course, thank you for your help with my first PR! Please let me know if you need anything else on this branch.

Copy link
Member

@Alvaro-Kothe Alvaro-Kothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if its really necessary strict=False

@mroeschke mroeschke added this to the 3.0 milestone Sep 25, 2025
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Sep 25, 2025
@mroeschke mroeschke merged commit 23926b5 into pandas-dev:main Sep 25, 2025
47 checks passed
@mroeschke
Copy link
Member

Thanks @anthonyspeicher and the review @Alvaro-Kothe

@anthonyspeicher anthonyspeicher deleted the zip-strict-core-internals branch September 25, 2025 21:51
jzwick pushed a commit to jzwick/pandas that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants