TST: Add regression test for pyarrow datetime merge with duplicates (GH#61926) #62592
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for GH#61926 to ensure merge operations work correctly with pyarrow datetime columns when there are duplicate values on the right side. This was fixed by PR#62276 which improved Index._get_join_target handling for pyarrow datetime types.
3 tasks
mroeschke
reviewed
Oct 5, 2025
mroeschke
requested changes
Oct 5, 2025
|
@mroeschke Done! Removed the extra comments and switched to tm.assert_frame_equal. Thanks for the feedback! |
mroeschke
approved these changes
Oct 6, 2025
|
Thanks @G26karthik |
5 tasks
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for issue #61926, which was fixed by PR #62276.
Issue:
Merge operations were failing with
ValueError: Length mismatchwhen using pyarrow datetime columns where the right dataframe had duplicate timestamps.Fix:
PR #62276 improved
Index._get_join_targetto properly handle pyarrow datetime types by casting them to int64 (i8) for join operations, similar to how numpy datetime types are handled.This PR:
Adds a test case to ensure this bug doesn't regress in the future. The test:
Closes #61926