TST: Reduce deep copies in the test suite #62970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Nov 4, 2025
| def test_to_xarray_index_types(self, index_flat, request): | ||
| # MultiIndex is tested in test_to_xarray_with_multiindex | ||
| index = index_flat | ||
| index = index_flat.copy(deep=False) |
Member
There was a problem hiding this comment.
not a super-strong opinion, but needing to do this as a policy feels weird.
Member
Author
There was a problem hiding this comment.
OK sure I can remove this case, but generally I feel like always some risk mutating a pytest fixture
Member
There was a problem hiding this comment.
Fair enough, I won’t complain
jbrockmendel
approved these changes
Nov 6, 2025
Member
|
thanks @mroeschke |
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most of the fixtures documentation that a copy is made to avoid changing attributes of Index/Series, a shallow copy should just be necessary instead of using a deep copy. But IMO tests should not be mutating fixtures