BUG: Error in gbq.py

[cast42]

Hi,

from  pandas.io import gbq

gives the following error:

>>> from  pandas.io import gbq
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/pandas/__init__.py", line 45, in <module>
    from pandas.io.api import *
  File "/usr/local/lib/python2.7/site-packages/pandas/io/api.py", line 15, in <module>
    from pandas.io.gbq import read_gbq
  File "/usr/local/lib/python2.7/site-packages/pandas/io/gbq.py", line 39, in <module>
    if LooseVersion(_GOOGLE_API_CLIENT_VERSION >= '1.2.0'):
  File "/usr/local/Cellar/python/2.7.8_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/version.py", line 265, in __init__
    self.parse(vstring)
  File "/usr/local/Cellar/python/2.7.8_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/version.py", line 274, in parse
    self.component_re.split(vstring))
TypeError: expected string or buffer

The error is in gbq.py line 46:

if LooseVersion(_GOOGLE_API_CLIENT_VERSION >= '1.2.0'):

Correct this to:

if LooseVersion(_GOOGLE_API_CLIENT_VERSION) >= '1.2.0':

to return true when the google api client has the correct version.

[jreback]

what pandas version?

[jreback]

cc @jacobschaer

[cast42]

>>> import pandas as pd
>>> pd.__version__
'0.14.1'

[jreback]

@cast42 looks like still a problem in 0.15.0

[cast42]

@jreback the typo was introduced here:
https://github.com/pydata/pandas/blob/56caedb69954ddbac05ff81180158bc06f8b41db/pandas/io/gbq.py
on June 27 2014

[cast42]

The same typo occurs also in line 59 of https://github.com/pydata/pandas/blob/master/pandas/io/gbq.py

            if LooseVersion(_GOOGLE_FLAGS_VERSION >= '2.0.0'):
                _GOOGLE_FLAGS_VALID_VERSION = True

must become:

            if LooseVersion(_GOOGLE_FLAGS_VERSION) >= '2.0.0':
                _GOOGLE_FLAGS_VALID_VERSION = True

[jreback]

@cast42 welcome for you to do a fix. Can you change the tests so that this will currently fail (and your fix makes it pass)? These are very tricky to test with the correct imports and such (they are really not tested per se, except locally by @jacobschaer)