Remove SKIP summary from CI logs #57011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Jan 22, 2024
There was a problem hiding this comment.
@lithomas1 pointed out you can just search for "failure" in the log and it jumps to the line I want. This works well and I've been doing it ever since. Still, if we think no one finds this generally useful (and I imagine that's the case), definitely very positive here.
|
+1 on this - sometimes the large amount of output does make my logs lag. |
|
+1 as well |
mroeschke
approved these changes
Jan 22, 2024
|
Thanks @WillAyd |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 22, 2024
mroeschke
pushed a commit
that referenced
this pull request
Jan 23, 2024
…#57020) Backport PR #57011: Remove SKIP summary from CI logs Co-authored-by: William Ayd <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was @rhshadrach idea originally. This currently generates about 3k lines of SKIPs in the CI output, which can be mildly annoying to have to scroll through every log