Skip to content

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 7, 2024 09:29
@MarcoGorelli MarcoGorelli requested a review from rhshadrach as a code owner March 7, 2024 10:10
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but is removing the imports here intentional?

@MarcoGorelli
Copy link
Member Author

lgtm, but is removing the imports here intentional?

ruff's failing on main, I think just from some prs being merged in close succession

@MarcoGorelli MarcoGorelli added this to the 2.2.2 milestone Mar 7, 2024
@MarcoGorelli MarcoGorelli merged commit 7977a37 into pandas-dev:main Mar 7, 2024
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 7, 2024
MarcoGorelli added a commit to meeseeksmachine/pandas that referenced this pull request Mar 7, 2024
mroeschke pushed a commit that referenced this pull request Mar 7, 2024
…7763)

* Backport PR #57759: DOC: add whatsnew for v2.2.2

* [skip-ci]

---------

Co-authored-by: Marco Edward Gorelli <[email protected]>
Co-authored-by: Marco Gorelli <[email protected]>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants