fix: Add Close Button to Animation Editor & Conditionally Show Save Button Across Windows (AscensionGameDev#2689)

* add close button and conditionally show Save button

* fix

* allow only close button on all editor windows

* allow only close button - projectile editor

* Panda Review I

* Weylon review

Author: TimtyG

Intersect.Editor/Forms/Editors/EditorForm.cs

@@ -1,3 +1,4 @@
+using DarkUI.Controls;
 using Intersect.Editor.Core;
 using Intersect.Editor.Networking;
 using Intersect.Enums;
@@ -12,6 +13,9 @@ public partial class EditorForm : Form
 
     private bool mClosing = false;
 
+    protected DarkButton? _btnSave;
+    protected DarkButton? _btnCancel;
+
     protected EditorForm()
     {
         Icon = Program.Icon;
@@ -83,4 +87,18 @@ private void InitializeComponent()
 
     }
 
+    protected void UpdateEditorButtons(bool isItemSelected)
+    {
+        if (_btnSave != null)
+        {
+            _btnSave.Visible = isItemSelected;
+            _btnSave.Enabled = isItemSelected;
+        }
+
+        if (_btnCancel != null)
+        {
+            _btnCancel.Visible = isItemSelected;
+            _btnCancel.Enabled = isItemSelected;
+        }
+    }
 }

Intersect.Editor/Forms/Editors/Events/frmEvent.Designer.cs

@@ -1,4 +1,4 @@
-using DarkUI.Forms;
+using DarkUI.Forms;
 using Intersect.Editor.Core;
 using Intersect.Editor.Forms.Editors.Events;
 using Intersect.Editor.General;
@@ -31,8 +31,12 @@ public FrmQuest()
         Icon = Program.Icon;
 
         InitLocalization();
+        _btnSave = btnSave;
+        _btnCancel = btnCancel;
 
         lstGameObjects.Init(UpdateToolStripItems, AssignEditorItem, toolStripItemNew_Click, toolStripItemCopy_Click, toolStripItemUndo_Click, toolStripItemPaste_Click, toolStripItemDelete_Click);
+
+        UpdateEditor();
     }
     private void AssignEditorItem(Guid id)
     {
@@ -121,6 +125,11 @@ protected override void GameObjectUpdatedDelegate(GameObjectType type)
         }
     }
 
+    private void FrmQuest_FormClosed(object sender, FormClosedEventArgs e)
+    {
+        btnCancel_Click(null, null);
+    }
+
     private void btnCancel_Click(object sender, EventArgs e)
     {
         foreach (var item in mChanged)
@@ -277,7 +286,10 @@ private void UpdateEditor()
         {
             pnlContainer.Hide();
         }
-
+        
+        var hasItem = mEditorItem != null;
+        
+        UpdateEditorButtons(hasItem);
         UpdateToolStripItems();
     }
 

Intersect.Editor/Forms/Editors/Quest/frmQuest.Designer.cs

@@ -527,7 +527,7 @@ private void tmrUpperAnimation_Tick(object sender, EventArgs e)
 
     private void frmAnimation_FormClosed(object sender, FormClosedEventArgs e)
     {
-        Globals.CurrentEditor = -1;
+        btnCancel_Click(null, null);
     }
 
     private void scrlLowerFrame_Scroll(object sender, ScrollValueEventArgs e)

Intersect.Editor/Forms/Editors/Quest/frmQuest.cs

@@ -1280,6 +1280,11 @@ private void UpdateExpGridValues(int start, int end = -1)
         }
     }
 
+    private void FrmClass_FormClosed(object sender, FormClosedEventArgs e)
+    {
+        btnCancel_Click(null, null);
+    }
+
     private void btnCloseExpGrid_Click(object sender, EventArgs e)
     {
         grpExpGrid.Hide();