ensure packet IDs are uniformly ordered regardless of user locale

pandinocoder · pandinocoder · commit 2494fbdc73a5 · 2025-03-05T15:25:10.000+01:00
diff --git a/Framework/Intersect.Framework.Core/Network/PacketTypeRegistry.cs b/Framework/Intersect.Framework.Core/Network/PacketTypeRegistry.cs
@@ -1,4 +1,5 @@
-﻿using Intersect.Collections;
+﻿using System.Globalization;
+using Intersect.Collections;
 using System.Reflection;
 using Intersect.Framework.Reflection;
 using Microsoft.Extensions.Logging;
@@ -55,7 +56,10 @@ public bool TryRegisterBuiltIn()
                     );
                 }
             )
-            .OrderBy(type => type.ToString());
+            .OrderBy(
+                type => type.GetName(qualified: true),
+                CultureInfo.InvariantCulture.CompareInfo.GetStringComparer(CompareOptions.Ordinal)
+            );
         BuiltInTypesInternal.AddRange(definedPacketTypes);
         return BuiltInTypesInternal.All(TryRegister) && BuiltInTypesInternal.Count > 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`		`-using Intersect.Collections;`
	`1`	`+using System.Globalization;`
	`2`	`+using Intersect.Collections;`
`2`	`3`	`using System.Reflection;`
`3`	`4`	`using Intersect.Framework.Reflection;`
`4`	`5`	`using Microsoft.Extensions.Logging;`
`@@ -55,7 +56,10 @@ public bool TryRegisterBuiltIn()`
`55`	`56`	`);`
`56`	`57`	`}`
`57`	`58`	`)`
`58`		`- .OrderBy(type => type.ToString());`
	`59`	`+ .OrderBy(`
	`60`	`+ type => type.GetName(qualified: true),`
	`61`	`+ CultureInfo.InvariantCulture.CompareInfo.GetStringComparer(CompareOptions.Ordinal)`
	`62`	`+ );`
`59`	`63`	`BuiltInTypesInternal.AddRange(definedPacketTypes);`
`60`	`64`	`return BuiltInTypesInternal.All(TryRegister) && BuiltInTypesInternal.Count > 0;`
`61`	`65`	`}`