server tests for Player

pandinocoder · pandinocoder · commit 32efc44ed03f · 2025-02-14T17:38:56.000+01:00
Experience tests added for:
- GiveExperience
- TakeExperience

Level tests added for:
- SetLevel
diff --git a/Framework/Intersect.Framework.Core/Config/Options.cs b/Framework/Intersect.Framework.Core/Config/Options.cs
@@ -226,8 +226,7 @@ public void FixAnimatedSprites()
 
     public static bool LoadFromDisk()
     {
-        Options instance = new();
-        Instance = instance;
+        var instance = EnsureCreated();
 
         var pathToServerConfig = Path.Combine(ResourcesDirectory, "config.json");
         if (!Directory.Exists(ResourcesDirectory))
@@ -248,6 +247,13 @@ public static bool LoadFromDisk()
         return true;
     }
 
+    internal static Options EnsureCreated()
+    {
+        Options instance = new();
+        Instance = instance;
+        return instance;
+    }
+
     public static void SaveToDisk()
     {
         if (Instance is not { } instance)
diff --git a/Framework/Intersect.Framework.Core/Intersect.Framework.Core.csproj b/Framework/Intersect.Framework.Core/Intersect.Framework.Core.csproj
@@ -21,6 +21,9 @@
     <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
       <_Parameter1>Intersect.Server.Core</_Parameter1>
     </AssemblyAttribute>
+    <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
+      <_Parameter1>Intersect.Tests.Server</_Parameter1>
+    </AssemblyAttribute>
   </ItemGroup>
 
     <ItemGroup>
diff --git a/Intersect.Tests.Server/Entities/PlayerTests.GiveExperience.cs b/Intersect.Tests.Server/Entities/PlayerTests.GiveExperience.cs
@@ -0,0 +1,55 @@
+using Intersect.Server.Entities;
+using NUnit.Framework;
+
+namespace Intersect.Tests.Server.Entities;
+
+public partial class PlayerTests
+{
+    private static IEnumerable<object[]> DataGiveExperience
+    {
+        get
+        {
+            Options.EnsureCreated();
+
+            yield return [1, 0, -1, 1, 0];
+            yield return [1, 0, 1, 1, 1];
+            yield return [1, 1, 1, 1, 2];
+            yield return [1, 99, 1, 2, 0];
+            yield return [1, 99, 2, 2, 1];
+            yield return [2, 0, -1, 2, 0]; // Because GiveExperience() has no "enable losing levels" boolean
+            yield return [2, 1, -1, 2, 0];
+            yield return [2, 1, -2, 2, 0];  // Because GiveExperience() has no "enable losing levels" boolean
+            yield return [Options.Instance.Player.MaxLevel - 1, 1, 1000, Options.Instance.Player.MaxLevel, 901];
+            yield return [Options.Instance.Player.MaxLevel, 1, 1000, Options.Instance.Player.MaxLevel, 1001];
+        }
+    }
+
+    [TestCaseSource(nameof(DataGiveExperience))]
+    public void TestGiveExperience(int initialLevel, int initialExperience, long experienceToGive, int expectedLevel, long expectedExperience)
+    {
+        Player player = new()
+        {
+            Level = initialLevel,
+            Exp = initialExperience,
+            MapId = _mapId,
+        };
+
+        Assert.Multiple(
+            () =>
+            {
+                Assert.That(player.Level, Is.EqualTo(initialLevel));
+                Assert.That(player.Exp, Is.EqualTo(initialExperience));
+            }
+        );
+
+        player.GiveExperience(experienceToGive);
+
+        Assert.Multiple(
+            () =>
+            {
+                Assert.That(player.Level, Is.EqualTo(expectedLevel));
+                Assert.That(player.Exp, Is.EqualTo(expectedExperience));
+            }
+        );
+    }
+}
diff --git a/Intersect.Tests.Server/Entities/PlayerTests.SetLevel.cs b/Intersect.Tests.Server/Entities/PlayerTests.SetLevel.cs
@@ -0,0 +1,53 @@
+using Intersect.Server.Entities;
+using NUnit.Framework;
+
+namespace Intersect.Tests.Server.Entities;
+
+public partial class PlayerTests
+{
+    private static IEnumerable<object[]> DataSetLevel
+    {
+        get
+        {
+            Options.EnsureCreated();
+
+            yield return [1, 1, 0, false, 1, 1];
+            yield return [1, 1, 0, true, 1, 1];
+            yield return [1, 1, 2, false, 2, 1];
+            yield return [1, 1, 2, true, 2, 0];
+            yield return [2, 1, 1, false, 1, 1];
+            yield return [2, 1, 1, true, 1, 0];
+            yield return [1, 1, Options.Instance.Player.MaxLevel + 1, false, Options.Instance.Player.MaxLevel, 1];
+            yield return [1, 1, Options.Instance.Player.MaxLevel + 1, true, Options.Instance.Player.MaxLevel, 0];
+        }
+    }
+
+    [TestCaseSource(nameof(DataSetLevel))]
+    public void TestSetLevel(int initialLevel, int initialExperience, int newLevel, bool resetExperience, int expectedLevel, long expectedExperience)
+    {
+        Player player = new()
+        {
+            Level = initialLevel,
+            Exp = initialExperience,
+            MapId = _mapId,
+        };
+
+        Assert.Multiple(
+            () =>
+            {
+                Assert.That(player.Level, Is.EqualTo(initialLevel));
+                Assert.That(player.Exp, Is.EqualTo(initialExperience));
+            }
+        );
+
+        player.SetLevel(level: newLevel, resetExperience: resetExperience);
+
+        Assert.Multiple(
+            () =>
+            {
+                Assert.That(player.Level, Is.EqualTo(expectedLevel));
+                Assert.That(player.Exp, Is.EqualTo(expectedExperience));
+            }
+        );
+    }
+}
diff --git a/Intersect.Tests.Server/Entities/PlayerTests.TakeExperience.cs b/Intersect.Tests.Server/Entities/PlayerTests.TakeExperience.cs
@@ -0,0 +1,84 @@
+using Intersect.Server.Entities;
+using NUnit.Framework;
+
+namespace Intersect.Tests.Server.Entities;
+
+public partial class PlayerTests
+{
+    private static IEnumerable<object[]> DataTakeExperience
+    {
+        get
+        {
+            Options.EnsureCreated();
+
+            yield return [1, 0, -1, true, true, 1, 1]; // Gives experience
+            yield return [1, 0, 1, true, true, 1, 0];
+            yield return [1, 1, 1, true, true, 1, 0];
+
+            yield return [1, 99, -1, true, true, 2, 0]; // Gives experience
+            yield return [1, 99, -1, true, false, 2, 0]; // Gives experience
+            yield return [1, 99, -1, false, true, 2, 0]; // Gives experience
+            yield return [1, 99, -1, false, false, 2, 0]; // Gives experience
+
+            yield return [1, 99, -2, true, true, 2, 1]; // Gives experience
+            yield return [1, 99, -2, true, false, 2, 1]; // Gives experience
+            yield return [1, 99, -2, false, true, 2, 1]; // Gives experience
+            yield return [1, 99, -2, false, false, 2, 1]; // Gives experience
+
+            yield return [2, 0, 1, true, true, 1, 99];
+            yield return [2, 0, 1, true, false, 1, 99];
+            yield return [2, 0, 1, false, true, 2, 0];
+            yield return [2, 0, 1, false, false, 2, 0];
+
+            yield return [2, 1, 1, true, true, 2, 0];
+            yield return [2, 1, 1, true, false, 2, 0];
+            yield return [2, 1, 1, false, true, 2, 0];
+            yield return [2, 1, 1, false, false, 2, 0];
+
+            yield return [2, 1, 2, true, true, 1, 99];
+            yield return [2, 1, 2, true, false, 1, 99];
+            yield return [2, 1, 2, false, true, 2, 0];
+            yield return [2, 1, 2, false, false, 2, 0];
+
+            yield return [Options.Instance.Player.MaxLevel, 0, 1, true, true, Options.Instance.Player.MaxLevel - 1, 99];
+            yield return [Options.Instance.Player.MaxLevel, 1, 1000, true, true, Options.Instance.Player.MaxLevel - 10, 1];
+        }
+    }
+
+    [TestCaseSource(nameof(DataTakeExperience))]
+    public void TestTakeExperience(
+        int initialLevel,
+        int initialExperience,
+        long experienceToTake,
+        bool enableLosingLevels,
+        bool force,
+        int expectedLevel,
+        long expectedExperience
+    )
+    {
+        Player player = new()
+        {
+            Level = initialLevel,
+            Exp = initialExperience,
+            MapId = _mapId,
+        };
+
+        Assert.Multiple(
+            () =>
+            {
+                Assert.That(player.Level, Is.EqualTo(initialLevel));
+                Assert.That(player.Exp, Is.EqualTo(initialExperience));
+            }
+        );
+
+        player.TakeExperience(experienceToTake, enableLosingLevels: enableLosingLevels, force: force);
+
+        Assert.Multiple(
+            () =>
+            {
+                Assert.That(player.Level, Is.EqualTo(expectedLevel));
+                Assert.That(player.Exp, Is.EqualTo(expectedExperience));
+            }
+        );
+    }
+}
diff --git a/Intersect.Tests.Server/Entities/PlayerTests.cs b/Intersect.Tests.Server/Entities/PlayerTests.cs
@@ -0,0 +1,19 @@
+using Intersect.Server.Maps;
+using NUnit.Framework;
+
+namespace Intersect.Tests.Server.Entities;
+
+[TestFixture]
+public partial class PlayerTests
+{
+    private Guid _mapId;
+
+    [SetUp]
+    public void Setup()
+    {
+        Options.EnsureCreated();
+
+        _mapId = Guid.NewGuid();
+        MapController.Lookup.Set(_mapId, new MapController(_mapId));
+    }
+}
diff --git a/Intersect.Tests.Server/Intersect.Tests.Server.csproj b/Intersect.Tests.Server/Intersect.Tests.Server.csproj
@@ -16,10 +16,17 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="MSTest.TestAdapter" Version="1.3.2" />
-    <PackageReference Include="MSTest.TestFramework" Version="1.3.2" />
-    <PackageReference Include="NUnit" Version="3.11.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="3.13.0" />
+    <PackageReference Include="coverlet.collector" Version="6.0.4">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
+    <PackageReference Include="NUnit" Version="4.3.2" />
+    <PackageReference Include="NUnit.Analyzers" Version="4.6.0">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="NUnit3TestAdapter" Version="5.0.0" />
   </ItemGroup>
 
 </Project>
diff --git a/Intersect.Tests.Server/Stub.cs b/Intersect.Tests.Server/Stub.cs
@@ -12,7 +12,7 @@ public void TestStub()
         {
             // Needed so NUnit doesn't return -2
             // TODO: Remove this when there are actual tests in this assembly
-            Assert.AreEqual(0, 0);
+            Assert.That(0, Is.EqualTo(0));
         }
 
     }

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public void TestStub()`
`12`	`12`	`{`
`13`	`13`	`// Needed so NUnit doesn't return -2`
`14`	`14`	`// TODO: Remove this when there are actual tests in this assembly`
`15`		`- Assert.AreEqual(0, 0);`
	`15`	`+ Assert.That(0, Is.EqualTo(0));`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`}`