fix: create 1 db/db_errors file logger per context type (AscensionGameDev#2061)

Author: pandinocoder

Intersect.Server.Core/Database/DatabaseTypeMigrationService.cs

@@ -186,14 +186,14 @@ PropertyInfo dbSetInfo
         await using var fromContext = IntersectDbContext<TContext>.Create(fromOptions with
         {
             DisableAutoInclude = true,
-            LoggerFactory = new IntersectLoggerFactory(),
+            LoggerFactory = new IntersectLoggerFactory(typeof(TContext).Name),
         });
         await using var toContext = IntersectDbContext<TContext>.Create(toOptions with
         {
             DisableAutoInclude = true,
             EnableDetailedErrors = true,
             EnableSensitiveDataLogging = true,
-            LoggerFactory = new IntersectLoggerFactory(),
+            LoggerFactory = new IntersectLoggerFactory(typeof(TContext).Name),
         });
 
         if (dbSetInfo.GetValue(fromContext) is not DbSet<T> fromDbSet)

Intersect.Server.Core/Database/DbInterface.cs

@@ -101,7 +101,7 @@ public static GameContext CreateGameContext(
             ExplicitLoad = explicitLoad,
             LazyLoading = lazyLoading,
 #if DEBUG
-            LoggerFactory = new IntersectLoggerFactory(),
+            LoggerFactory = new IntersectLoggerFactory(nameof(GameContext)),
 #endif
             QueryTrackingBehavior = queryTrackingBehavior,
             ReadOnly = readOnly,
@@ -129,7 +129,7 @@ public static PlayerContext CreatePlayerContext(
             ExplicitLoad = explicitLoad,
             LazyLoading = lazyLoading,
 #if DEBUG
-            LoggerFactory = new IntersectLoggerFactory(),
+            LoggerFactory = new IntersectLoggerFactory(nameof(PlayerContext)),
 #endif
             QueryTrackingBehavior = queryTrackingBehavior,
             ReadOnly = readOnly,
@@ -152,7 +152,7 @@ internal static LoggingContext CreateLoggingContext(
             ExplicitLoad = explicitLoad,
             LazyLoading = lazyLoading,
 #if DEBUG
-            LoggerFactory = new IntersectLoggerFactory(),
+            LoggerFactory = new IntersectLoggerFactory(nameof(LoggingContext)),
 #endif
             QueryTrackingBehavior = queryTrackingBehavior,
             ReadOnly = readOnly,
@@ -284,7 +284,7 @@ private static bool EnsureUpdated(IServerContext serverContext)
                 DatabaseType = Options.Instance.GameDatabase.Type,
                 EnableDetailedErrors = true,
                 EnableSensitiveDataLogging = true,
-                LoggerFactory = new IntersectLoggerFactory(),
+                LoggerFactory = new IntersectLoggerFactory(nameof(GameContext)),
             });
 
             Log.Verbose("Creating player context...");
@@ -297,7 +297,7 @@ private static bool EnsureUpdated(IServerContext serverContext)
                 DatabaseType = Options.Instance.PlayerDatabase.Type,
                 EnableDetailedErrors = true,
                 EnableSensitiveDataLogging = true,
-                LoggerFactory = new IntersectLoggerFactory(),
+                LoggerFactory = new IntersectLoggerFactory(nameof(PlayerContext)),
             });
 
             Log.Verbose("Creating logging context...");
@@ -310,7 +310,7 @@ private static bool EnsureUpdated(IServerContext serverContext)
                 DatabaseType = Options.Instance.LoggingDatabase.Type,
                 EnableDetailedErrors = true,
                 EnableSensitiveDataLogging = true,
-                LoggerFactory = new IntersectLoggerFactory(),
+                LoggerFactory = new IntersectLoggerFactory(nameof(LoggingContext)),
             });
 
             // We don't want anyone running the old migration tool accidentally

Intersect.Server.Core/Database/IntersectLoggerFactory.cs

@@ -13,19 +13,21 @@ namespace Intersect.Server.Database;
 
 internal sealed class IntersectLoggerFactory : ILoggerFactory
 {
-    private static string ExecutableName => Path.GetFileNameWithoutExtension(
-        Process.GetCurrentProcess().MainModule?.FileName ?? Assembly.GetExecutingAssembly().GetName().Name
-    );
+    private static readonly Dictionary<string, ImmutableArray<ILogOutput>> _cachedOutputs = new();
 
     private readonly DbLoggerProvider _loggerProvider;
 
-    internal IntersectLoggerFactory()
+    internal IntersectLoggerFactory(string name)
     {
-        var outputs = ImmutableList.Create<ILogOutput>(
-            new FileOutput($"db-{ExecutableName}.log"),
-            new FileOutput($"errors-{ExecutableName}.log", IntersectLogLevel.Error),
-            new ConciseConsoleOutput(Debugger.IsAttached ? IntersectLogLevel.Warn : IntersectLogLevel.Error)
-        );
+        if (!_cachedOutputs.TryGetValue(name, out var outputs))
+        {
+            outputs = ImmutableArray.Create<ILogOutput>(
+                new FileOutput(Log.SuggestFilename(prefix: $"db-{name}-")),
+                new FileOutput(Log.SuggestFilename(prefix: $"db_errors-{name}-"), IntersectLogLevel.Error),
+                new ConciseConsoleOutput(Debugger.IsAttached ? IntersectLogLevel.Warn : IntersectLogLevel.Error)
+            );
+            _cachedOutputs[name] = outputs;
+        }
 
         _loggerProvider = new DbLoggerProvider(
             new Logger(