properly mark update as failed

Author: pandinocoder

Framework/Intersect.Framework.Core/AssetManagement/Updater.cs

@@ -384,6 +384,11 @@ private void RunUpdates(CancellationToken cancellationToken)
                     throw new UnreachableException();
             }
 
+            if (updateManifest == null)
+            {
+                throw new InvalidOperationException($"Manifest is null despite a status of {manifestStatus}");
+            }
+
             assetManifest = new UpdateManifest
             {
                 StreamingUrl = updateManifest.StreamingUrl,
@@ -518,9 +523,26 @@ private void RunUpdates(CancellationToken cancellationToken)
             thread.Join();
         }
 
+        if (!_failed)
+        {
+            foreach (var (file, result) in _downloadResults)
+            {
+                if (result.State != DownloadState.Failed)
+                {
+                    continue;
+                }
+
+                ApplicationContext.CurrentContext.Logger.LogError(
+                    "Download of {File} marked as {DownloadState}, marking update as failed",
+                    file.Path,
+                    result.State
+                );
+                _failed = true;
+            }
+        }
+
         if (_failed)
         {
-            _failed = true;
             Status = UpdateStatus.Error;
             return;
         }
@@ -808,8 +830,8 @@ private bool StreamDownloads(UpdateManifest updateManifest, CancellationToken ca
                 try
                 {
                     if (targetFileInfo.Exists)
-                    {
-                        targetFileInfo.Delete();
+                        {
+                            targetFileInfo.Delete();
                     }
                 }
                 catch (Exception exception)