feat: (Day) Add option to allow safe zones to consider any player friendly (AscensionGameDev#2071)

* feat: (Day) Add option to enable friendly fire in safe map zones for non party/guildies

* chore: (Day) Code review

* chore: Code review

Author: AlexVild

Intersect (Core)/Config/CombatOptions.cs

@@ -73,5 +73,10 @@ public partial class CombatOptions
         /// If enabled, this makes it so a player casting a friendly spell on a hostile target instead casts the spell upon themselves
         /// </summary>
         public bool EnableAutoSelfCastFriendlySpellsWhenTargetingHostile { get; set; } = false;
+
+        /// <summary>
+        /// If enabled, this allows players to cast friendly spells on players who aren't in their guild or party
+        /// </summary>
+        public bool EnableAllPlayersFriendlyInSafeZone { get; set; } = false;
     }
 }

Intersect.Server.Core/Entities/Player.cs

@@ -5124,7 +5124,22 @@ public override bool IsAllyOf(Entity otherEntity)
 
         public virtual bool IsAllyOf(Player otherPlayer)
         {
-            return this.InParty(otherPlayer) || this == otherPlayer;
+            if (Id == otherPlayer.Id)
+            {
+                return true;
+            }
+
+            if (InParty(otherPlayer))
+            {
+                return true;
+            }
+
+            if (IsInGuild && otherPlayer?.Guild?.Id == Guild.Id)
+            {
+                return true;
+            }
+
+            return Map?.ZoneType == MapZone.Safe && Options.Instance.CombatOpts.EnableAllPlayersFriendlyInSafeZone;
         }
 
         public override bool CanCastSpell(SpellBase spell, Entity target, bool checkVitalReqs, out SpellCastFailureReason reason)