LiteNetLib only puts arrays that are up to 65K into the packet if you use the PutArrays() method

Author: pandinocoder

Intersect.Network/LiteNetLib/LiteNetLibConnection.cs

@@ -93,15 +93,20 @@ internal bool TryProcessInboundMessage(
     {
         buffer = default;
 
-        var cipherdata = reader.GetBytesWithLength();
+        reader.Get(out int cipherdataLength);
+        var cipherdata = new byte[cipherdataLength];
+        reader.GetBytes(cipherdata, cipherdataLength);
 
 #if DEBUG
         byte[]? debugPlaindata = null;
+        int debugPlaindataLength;
         if (Debugger.IsAttached)
         {
             if (!reader.EndOfData)
             {
-                debugPlaindata = reader.GetBytesWithLength();
+                reader.Get(out debugPlaindataLength);
+                debugPlaindata = new byte[debugPlaindataLength];
+                reader.GetBytes(debugPlaindata, debugPlaindataLength);
             }
         }
 #endif
@@ -167,12 +172,18 @@ public override bool Send(IPacket packet, TransmissionMode transmissionMode = Tr
 #endif
 
         NetDataWriter data = new(true, cipherdata.Length + sizeof(byte));
-        data.Put((byte)1);
-        data.PutBytesWithLength(cipherdata.ToArray());
+        data.Put((byte)0x20);
+        data.Put((byte)0x21);
+        data.Put((byte)0x22);
+        data.Put((byte)0x23);
+
+        data.Put(cipherdata.Length);
+        data.Put(cipherdata);
 #if DEBUG
         if (Debugger.IsAttached)
         {
-            data.PutBytesWithLength(packetData);
+            data.Put(packetData.Length);
+            data.Put(packetData);
         }
 #endif
         return Send(data, transmissionMode);

Intersect.Network/LiteNetLib/LiteNetLibInterface.cs

@@ -304,8 +304,29 @@ DeliveryMethod deliveryMethod
         // ReSharper disable once ConvertIfStatementToSwitchStatement
         if (packetCode > 1)
         {
-            ApplicationContext.Context.Value?.Logger.LogWarning($"Invalid packet code from {peer} / {connection.Guid}");
-            return;
+            if (packetCode != 0x20)
+            {
+                ApplicationContext.Context.Value?.Logger.LogWarning($"Invalid packet code from {peer} / {connection.Guid}");
+                return;
+            }
+
+            if (reader.GetByte() != 0x21)
+            {
+                ApplicationContext.Context.Value?.Logger.LogWarning($"Invalid packet code from {peer} / {connection.Guid}");
+                return;
+            }
+
+            if (reader.GetByte() != 0x22)
+            {
+                ApplicationContext.Context.Value?.Logger.LogWarning($"Invalid packet code from {peer} / {connection.Guid}");
+                return;
+            }
+
+            if (reader.GetByte() != 0x23)
+            {
+                ApplicationContext.Context.Value?.Logger.LogWarning($"Invalid packet code from {peer} / {connection.Guid}");
+                return;
+            }
         }
 
         if (packetCode == 0)

Intersect.Server.Core/Networking/PacketSender.cs

@@ -726,7 +726,14 @@ public static void SendGameData(Client client)
         }
 
         //Now send the cached game data that we send to all clients
-        client.Send(CachedGameDataPacket);
+        if (!client.Send(CachedGameDataPacket))
+        {
+            ApplicationContext.CurrentContext.Logger.LogError(
+                "Failed to send cached game data packet to {ClientId} ({ClientType})",
+                client.Id,
+                client.IsEditor ? "editor" : "player"
+            );
+        }
     }
 
     //GameDataPacket