performance fixes on DebugWindow

With the DebugWindow open for a while the FPS would slowly creep down to nearly 0, and from the profiler it appeared to be clustered in MoveNext in the different threaded async value generators. I'm hoping the more active value providers will be more performant.

Author: pandinocoder

Intersect.Client.Core/Core/Graphics.cs

@@ -529,7 +529,7 @@ public static void DrawInGame(TimeSpan deltaTime)
     }
 
     //Game Rendering
-    public static void Render(TimeSpan deltaTime, TimeSpan _)
+    public static void Render(TimeSpan deltaTime, TimeSpan totalTime)
     {
         var takingScreenshot = false;
         if (Renderer?.ScreenshotRequests.Count > 0)
@@ -592,7 +592,7 @@ public static void Render(TimeSpan deltaTime, TimeSpan _)
 
         Renderer.Scale = Globals.Database.UIScale;
 
-        Interface.Interface.DrawGui();
+        Interface.Interface.DrawGui(deltaTime, totalTime);
 
         DrawGameTexture(
             Renderer.GetWhiteTexture(), new FloatRect(0, 0, 1, 1), CurrentView,

Intersect.Client.Core/Core/Main.cs

@@ -98,6 +98,8 @@ public static void Update(TimeSpan deltaTime)
             Globals.InputManager.Update(deltaTime);
             Audio.Update();
 
+            Time.Update();
+
             Globals.OnGameUpdate(deltaTime);
         }
     }
@@ -267,7 +269,6 @@ private static void ProcessGame()
         }
 
         Graphics.UpdatePlayerLight();
-        Time.Update();
     }
 
     public static void JoinGame()

Intersect.Client.Core/General/Time.cs

@@ -29,6 +29,12 @@ public static void LoadTime(DateTime timeUpdate, Color clr, float rate)
 
     public static void Update()
     {
+        if (!Networking.Network.IsConnected)
+        {
+            sServerTime = DateTime.Now;
+            return;
+        }
+
         if (sUpdateTime < Timing.Global.Milliseconds)
         {
             var ts = new TimeSpan(0, 0, 0, 0, (int) (1000 * sRate));

Intersect.Client.Core/Interface/Debugging/DebugWindow.cs

@@ -0,0 +1,16 @@
+using Intersect.Client.Entities;
+using Intersect.Client.General;
+using Intersect.Client.Interface.Data;
+
+namespace Intersect.Client.Interface.Debugging.Providers;
+
+public sealed class ActivePlayerProvider(TimeSpan delay) : DelayedDataProvider<Player?>(delay)
+{
+    public ActivePlayerProvider() : this(MinimumDelay) { }
+
+    protected override bool TryDelayedUpdate(TimeSpan elapsed, TimeSpan total)
+    {
+        var newValue = Globals.Me;
+        return TrySetValue(newValue);
+    }
+}

Intersect.Client.Core/Interface/Debugging/Providers/ActivePlayerProvider.cs

@@ -0,0 +1,17 @@
+using Intersect.Client.Framework.Gwen.Control;
+using Intersect.Client.Interface.Data;
+
+namespace Intersect.Client.Interface.Debugging.Providers;
+
+public sealed class NodeUnderCursorProvider(TimeSpan delay) : DelayedDataProvider<Base?>(delay)
+{
+    public NodeUnderCursorProvider() : this(MinimumDelay) { }
+
+    public NodeFilter Filter { get; set; } = NodeFilter.IncludeMouseInputDisabled;
+
+    protected override bool TryDelayedUpdate(TimeSpan elapsed, TimeSpan total)
+    {
+        var newValue = Interface.FindComponentUnderCursor(Filter);
+        return TrySetValue(newValue);
+    }
+}

Intersect.Client.Core/Interface/Debugging/Providers/NodeUnderCursorProvider.cs

@@ -322,7 +322,7 @@ public void AdminWindowSelectName(string playerName)
         adminWindow.PlayerName = playerName;
     }
 
-    public void Update()
+    public void Update(TimeSpan elapsed, TimeSpan total)
     {
         if (Globals.Me != null && PlayerBox?.MyEntity != Globals.Me)
         {
@@ -509,9 +509,9 @@ public void Update()
         }
     }
 
-    public void Draw()
+    public void Draw(TimeSpan elapsed, TimeSpan total)
     {
-        GameCanvas.RenderCanvas();
+        GameCanvas.RenderCanvas(elapsed, total);
     }
 
     private void CloseShop()

Intersect.Client.Core/Interface/Game/GameInterface.cs

@@ -169,7 +169,7 @@ public static bool HasInputFocus() =>
     #region "GUI Functions"
 
     //Actual Drawing Function
-    public static void DrawGui()
+    public static void DrawGui(TimeSpan elapsed, TimeSpan total)
     {
         if (!GwenInitialized)
         {
@@ -178,11 +178,11 @@ public static void DrawGui()
 
         if (Globals.GameState == GameStates.Menu)
         {
-            MenuUi.Update();
+            MenuUi.Update(elapsed, total);
         }
         else if (Globals.GameState == GameStates.InGame)
         {
-            GameUi.Update();
+            GameUi.Update(elapsed, total);
         }
 
         //Do not allow hiding of UI under several conditions
@@ -193,7 +193,7 @@ public static void DrawGui()
         sGameCanvas.RestrictToParent = false;
         if (Globals.GameState == GameStates.Menu)
         {
-            MenuUi.Draw();
+            MenuUi.Draw(elapsed, total);
         }
         else if (Globals.GameState == GameStates.InGame)
         {
@@ -210,7 +210,7 @@ public static void DrawGui()
                 {
                     sGameCanvas.Show();
                 }
-                GameUi.Draw();
+                GameUi.Draw(elapsed, total);
             }
         }
     }
@@ -266,7 +266,7 @@ public static void EnqueueInGame(Action action)
         _onCreatedGameUi.Enqueue(action);
     }
 
-    public static Framework.Gwen.Control.Base? FindComponentUnderCursor(ComponentStateFilters filters = default)
+    public static Framework.Gwen.Control.Base? FindComponentUnderCursor(NodeFilter filters = default)
     {
         var cursor = new Point(InputHandler.MousePosition.X, InputHandler.MousePosition.Y);
         var componentUnderCursor = CurrentInterface?.Root.GetComponentAt(cursor, filters);

Intersect.Client.Core/Interface/Interface.cs

@@ -206,7 +206,7 @@ private void UsernameInputClicked(Base sender, MouseButtonState arguments)
             text => _usernameInput.Text = text ?? string.Empty,
             Strings.LoginWindow.Username,
             _usernameInput.Text,
-            inputBounds: _usernameInput.BoundsGlobal
+            inputBounds: _usernameInput.GlobalBounds
         );
     }
 

Intersect.Client.Core/Interface/Menu/LoginWindow.cs

@@ -118,7 +118,7 @@ public static void HandleReceivedConfiguration()
     }
 
     //Methods
-    public void Update()
+    public void Update(TimeSpan elapsed, TimeSpan total)
     {
         if (_mainMenuWindow.IsVisible)
         {