File tree Expand file tree Collapse file tree 4 files changed +7
-7
lines changed
backend/python/typecheck/mypy Expand file tree Collapse file tree 4 files changed +7
-7
lines changed Original file line number Diff line number Diff line change @@ -411,7 +411,6 @@ async def mypy_determine_partitions(
411411 )
412412
413413
414- # TODO(#10864): Improve performance, e.g. by leveraging the MyPy cache.
415414@rule (desc = "Typecheck using MyPy" , level = LogLevel .DEBUG )
416415async def mypy_typecheck (request : MyPyRequest , mypy : MyPy ) -> CheckResults :
417416 if mypy .skip :
Original file line number Diff line number Diff line change @@ -108,8 +108,9 @@ class LocalEnvironmentTarget(Target):
108108 Only one `local_environment` may be defined in `[environments-preview].names` per platform, and
109109 when `{ LOCAL_ENVIRONMENT_MATCHER } ` is specified as the environment, the
110110 `local_environment` that matches the current platform (if defined) will be selected.
111+
112+ See https://www.pantsbuild.org/stable/docs/using-pants/environments for more information.
111113 """
112- # TODO(#17096) Add a link to the environments docs once they land.
113114 )
114115
115116
@@ -256,8 +257,9 @@ class DockerEnvironmentTarget(Target):
256257 **Enable default Docker socket** is enabled, you can find it in **Docker Desktop Settings > Advanced**
257258 panel. That option tells Docker to create a socket at `/var/run/docker.sock` which Pants can use to
258259 communicate with Docker.
260+
261+ See https://www.pantsbuild.org/stable/docs/using-pants/environments for more information.
259262 """
260- # TODO(#17096) Add a link to the environments docs once they land.
261263 )
262264
263265
@@ -352,8 +354,9 @@ class RemoteEnvironmentTarget(Target):
352354 repository, but it can be useful to have >1 so that you can set different
353355 `extra_platform_properties`. For example, with some servers, you could use this to
354356 configure a different Docker image per environment.
357+
358+ See https://www.pantsbuild.org/stable/docs/using-pants/environments for more information.
355359 """
356- # TODO(#17096) Add a link to the environments docs once they land.
357360 )
358361
359362
Original file line number Diff line number Diff line change @@ -510,7 +510,7 @@ def build_pants_wheels() -> None:
510510
511511 args = (
512512 "./pants" ,
513- # TODO(# 9924) .
513+ # See https://github.com/pantsbuild/pants/issues/ 9924 for tty detection issues .
514514 "--no-dynamic-ui" ,
515515 # TODO(#7654): It's not safe to use Pantsd because we're already using Pants to run
516516 # this script.
Original file line number Diff line number Diff line change @@ -1569,7 +1569,6 @@ fn rule_graph_consumed_types<'py>(
15691569fn rule_graph_visualize ( py_scheduler : & Bound < ' _ , PyScheduler > , path : PathBuf ) -> PyO3Result < ( ) > {
15701570 let core = & py_scheduler. borrow ( ) . 0 . core ;
15711571 core. executor . enter ( || {
1572- // TODO(#7117): we want to represent union types in the graph visualizer somehow!!!
15731572 write_to_file ( path. as_path ( ) , & core. rule_graph ) . map_err ( |e| {
15741573 PyIOError :: new_err ( format ! (
15751574 "Failed to visualize to {}: {:?}" ,
@@ -1596,7 +1595,6 @@ fn rule_subgraph_visualize(
15961595 . collect :: < Vec < _ > > ( ) ;
15971596 let product_type = TypeId :: new ( product_type) ;
15981597
1599- // TODO(#7117): we want to represent union types in the graph visualizer somehow!!!
16001598 let subgraph = scheduler
16011599 . core
16021600 . rule_graph
You can’t perform that action at this time.
0 commit comments