Skip to content

Commit e774160

Browse files
authored
fix(publish): inverted logic of noninteractive log on failure (#23154)
The logic condition was inverted for only logging failures from noninteractive publish processes. It was only logging on success if set to log failures. πŸ˜ƒ
1 parent 2804a46 commit e774160

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

β€Ždocs/notes/2.32.x.mdβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ For `generate-lockfiles`, typos in the name of a resolve now give "Did you mean?
5252

5353
`PublishFieldSet` now has a `check_skip_request` hook to enable preemptive skips of packaging requests for targets where the publishing will be skipped (such as when a `skip_push=True` field exists).
5454

55+
Fixed inverted logic when setting noninteractive_process_output to only log failures.
56+
5557
### Backends
5658

5759
#### Docker

β€Žsrc/python/pants/core/goals/publish.pyβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ async def run_publish(
525525

526526
if publish.noninteractive_process_output == ShowOutput.ALL or (
527527
publish.noninteractive_process_output == ShowOutput.FAILED
528-
and background_res.exit_code == 0
528+
and background_res.exit_code != 0
529529
):
530530
console.print_stdout(output_msg)
531531

0 commit comments

Comments
Β (0)