Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/python/pants/backend/python/typecheck/mypy/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,6 @@ async def mypy_determine_partitions(
)


# TODO(#10864): Improve performance, e.g. by leveraging the MyPy cache.
@rule(desc="Typecheck using MyPy", level=LogLevel.DEBUG)
async def mypy_typecheck(request: MyPyRequest, mypy: MyPy) -> CheckResults:
if mypy.skip:
Expand Down
9 changes: 6 additions & 3 deletions src/python/pants/core/environments/target_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ class LocalEnvironmentTarget(Target):
Only one `local_environment` may be defined in `[environments-preview].names` per platform, and
when `{LOCAL_ENVIRONMENT_MATCHER}` is specified as the environment, the
`local_environment` that matches the current platform (if defined) will be selected.

See https://www.pantsbuild.org/stable/docs/using-pants/environments for more information.
"""
# TODO(#17096) Add a link to the environments docs once they land.
)


Expand Down Expand Up @@ -256,8 +257,9 @@ class DockerEnvironmentTarget(Target):
**Enable default Docker socket** is enabled, you can find it in **Docker Desktop Settings > Advanced**
panel. That option tells Docker to create a socket at `/var/run/docker.sock` which Pants can use to
communicate with Docker.

See https://www.pantsbuild.org/stable/docs/using-pants/environments for more information.
"""
# TODO(#17096) Add a link to the environments docs once they land.
)


Expand Down Expand Up @@ -352,8 +354,9 @@ class RemoteEnvironmentTarget(Target):
repository, but it can be useful to have >1 so that you can set different
`extra_platform_properties`. For example, with some servers, you could use this to
configure a different Docker image per environment.

See https://www.pantsbuild.org/stable/docs/using-pants/environments for more information.
"""
# TODO(#17096) Add a link to the environments docs once they land.
)


Expand Down
2 changes: 1 addition & 1 deletion src/python/pants_release/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ def build_pants_wheels() -> None:

args = (
"./pants",
# TODO(#9924).
# See https://github.com/pantsbuild/pants/issues/9924 for tty detection issues.
"--no-dynamic-ui",
# TODO(#7654): It's not safe to use Pantsd because we're already using Pants to run
# this script.
Expand Down
2 changes: 0 additions & 2 deletions src/rust/engine/src/externs/interface.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1569,7 +1569,6 @@ fn rule_graph_consumed_types<'py>(
fn rule_graph_visualize(py_scheduler: &Bound<'_, PyScheduler>, path: PathBuf) -> PyO3Result<()> {
let core = &py_scheduler.borrow().0.core;
core.executor.enter(|| {
// TODO(#7117): we want to represent union types in the graph visualizer somehow!!!
write_to_file(path.as_path(), &core.rule_graph).map_err(|e| {
PyIOError::new_err(format!(
"Failed to visualize to {}: {:?}",
Expand All @@ -1596,7 +1595,6 @@ fn rule_subgraph_visualize(
.collect::<Vec<_>>();
let product_type = TypeId::new(product_type);

// TODO(#7117): we want to represent union types in the graph visualizer somehow!!!
let subgraph = scheduler
.core
.rule_graph
Expand Down
Loading