refactor: improve static find performance

Author: panva

lib/helpers/initialize_clients.js

@@ -2,19 +2,23 @@ import instance from './weak_cache.js';
 import isPlainObject from './_/is_plain_object.js';
 import { InvalidClientMetadata } from './errors.js';
 
-function addStatic(metadata) {
-  const { staticClients } = instance(this);
-  if (!isPlainObject(metadata) || !metadata.client_id) {
-    throw new InvalidClientMetadata('client_id is mandatory property for statically configured clients');
-  }
+export default function initializeClients(clients = []) {
+  let staticClients;
 
-  if (staticClients.has(metadata.client_id)) {
-    throw new InvalidClientMetadata('client_id must be unique amongst statically configured clients');
-  }
+  for (const metadata of clients) {
+    if (!isPlainObject(metadata) || !metadata.client_id) {
+      throw new InvalidClientMetadata('client_id is mandatory property for statically configured clients');
+    }
 
-  staticClients.set(metadata.client_id, structuredClone(metadata));
-}
+    if (staticClients?.has(metadata.client_id)) {
+      throw new InvalidClientMetadata('client_id must be unique amongst statically configured clients');
+    }
 
-export default function initializeClients(clients = []) {
-  clients.map(addStatic, this);
+    staticClients ||= new Map();
+    staticClients.set(metadata.client_id, structuredClone(metadata));
+  }
+
+  if (staticClients) {
+    instance(this).staticClients = staticClients;
+  }
 }

lib/models/client.js

@@ -515,25 +515,25 @@ export default function getClient(provider) {
     }
 
     static async find(id) {
-      if (typeof id !== 'string') {
+      if (typeof id !== 'string' || !id.length) {
         return undefined;
       }
 
       const { staticClients, dynamicClients } = instance(provider);
 
-      if (staticClients.has(id)) {
-        const cached = staticClients.get(id);
-
+      const cached = staticClients?.get(id);
+      if (cached) {
         if (!(cached instanceof Client)) {
           const client = new Client(cached);
           if (client.sectorIdentifierUri !== undefined) {
             await sectorValidate(provider, client);
           }
           Object.defineProperty(client, 'noManage', { value: true });
           staticClients.set(id, client);
+          return client;
         }
 
-        return staticClients.get(id);
+        return cached;
       }
 
       const properties = await this.adapter.find(id);

lib/provider.js

@@ -62,7 +62,6 @@ export class Provider extends Koa {
   #exec;
 
   #int = {
-    staticClients: new Map(),
     dynamicClients: new QuickLRU({ maxSize: 100 }),
   };