refactor: client schema defaults and static props

Author: panva

lib/consts/client_attributes.js

@@ -27,7 +27,7 @@ const RECOGNIZED_METADATA = [
   'tos_uri',
 ];
 
-const DEFAULT = {
+const DEFAULTS = {
   application_type: 'web',
   authorization_signed_response_alg: 'RS256',
   backchannel_logout_session_required: false,
@@ -175,7 +175,7 @@ const SYNTAX = {
 export {
   ARYS,
   BOOL,
-  DEFAULT,
+  DEFAULTS,
   ENUM,
   HTTPS_URI,
   LOOPBACKS,

lib/helpers/client_schema.js

@@ -16,11 +16,9 @@ const needsJwks = {
 const {
   ARYS,
   BOOL,
-  DEFAULT: DEFAULTS,
   ENUM: ENUMS,
   HTTPS_URI,
   LOOPBACKS,
-  RECOGNIZED_METADATA: RECOGNIZED,
   REQUIRED,
   STRING,
   SYNTAX,
@@ -36,13 +34,13 @@ export default function getSchema(provider) {
   const { configuration, features } = instance(provider);
   const { scopes } = configuration;
 
-  const RECOGNIZED_METADATA = [...RECOGNIZED];
-  const DEFAULT = structuredClone(DEFAULTS);
+  const RECOGNIZED_METADATA = structuredClone(CLIENT_ATTRIBUTES.RECOGNIZED_METADATA);
+  const DEFAULTS = structuredClone(CLIENT_ATTRIBUTES.DEFAULTS);
   const DEFAULT_CONFIGURATION = structuredClone(configuration.clientDefaults);
-  Object.assign(DEFAULT, DEFAULT_CONFIGURATION);
+  Object.assign(DEFAULTS, DEFAULT_CONFIGURATION);
 
   if (configuration.subjectTypes.size === 1 && configuration.subjectTypes.has('pairwise')) {
-    DEFAULT.subject_type = 'pairwise';
+    DEFAULTS.subject_type = 'pairwise';
   }
 
   if (features.mTLS.enabled && features.mTLS.tlsClientAuth) {
@@ -213,7 +211,7 @@ export default function getSchema(provider) {
       Object.assign(
         this,
         omitBy(
-          pick(DEFAULT, ...RECOGNIZED_METADATA),
+          pick(DEFAULTS, ...RECOGNIZED_METADATA),
           isUndefined,
         ),
         omitBy(