Skip to content

Commit 0a6ff72

Browse files
author
Marcin Kardas
committed
Add independent proposal
Add a proposal with the best task, dataset and metric being choosen independently.
1 parent 7384a39 commit 0a6ff72

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

sota_extractor2/data/elastic.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -354,18 +354,17 @@ def display_fragment(f, cell_type="", display=True):
354354
return html
355355

356356

357-
def get_evidences_for_taxonomy(paper_id, task, dataset, metric, value):
357+
def query_for_evidences(paper_id, values, topk=5):
358358
evidence_query = Fragment.search().highlight(
359359
'text', pre_tags="<b>", post_tags="</b>", fragment_size=50)
360360

361-
values = [task, dataset, metric, value]
362361
query = {
363362
"query": ' '.join(values)
364363
}
365364

366365
fragments = list(evidence_query
367366
.filter('term', paper_id=paper_id)
368-
.query('match', text=query)[:5]
367+
.query('match', text=query)[:topk]
369368
)
370369

371370
return '\n'.join([' '.join(f.meta['highlight']['text']) for f in fragments])

sota_extractor2/models/linking/context_search.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def __init__(self, taxonomy, evidence_finder, context_noise=(0.5, 0.1, 0.2, 0.2,
180180
self.reverse_metrics_p = self._numba_update_nested_dict(reverse_probs(metrics_p))
181181
self.reverse_tasks_p = self._numba_update_nested_dict(reverse_probs(tasks_p))
182182
self.debug_gold_df = debug_gold_df
183-
self.max_repetitions = 1
183+
self.max_repetitions = 3
184184

185185
def _numba_update_nested_dict(self, nested):
186186
d = typed.Dict()
@@ -292,6 +292,16 @@ def __call__(self, query, paper_context, abstract_context, table_context, captio
292292
entry.update({"evidence": "", "confidence": prob})
293293
entries.append(entry)
294294

295+
best_independent = dict(
296+
task=top_results_t[0][0],
297+
dataset=top_results_d[0][0],
298+
metric=top_results_m[0][0])
299+
best_independent.update({
300+
"evidence": "",
301+
"confidence": 0.79
302+
})
303+
entries.append(best_independent)
304+
295305
# entries = []
296306
# for i in range(5):
297307
# best_independent = dict(
@@ -310,7 +320,7 @@ def __call__(self, query, paper_context, abstract_context, table_context, captio
310320
# p = pd.DataFrame({k:[v] for k, v in entry.items()})
311321
# p["evidence"] = ""
312322
# p["confidence"] = best_p
313-
p = pd.DataFrame(entries)
323+
p = pd.DataFrame(entries).sort_values("confidence", ascending=False)
314324

315325
self.queries[key] = p
316326

sota_extractor2/models/linking/manual_dicts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
'Word Accuracy': ['accuracy', 'word accuracy', 'acc', 'word acc'],
1616
'ROUGE-1': ['r1'],
1717
'ROUGE-2': ['r2'],
18-
'ROUGE-F': ['rf'],
18+
'ROUGE-L': ['rl'],
1919
'Precision': ['precision'],
2020
'Recall': ['recall'],
2121
# RAIN REMOVAL

0 commit comments

Comments
 (0)