Should StageError::Internal
be fatal?
#457
Locked
onbjerg
started this conversation in
Technical discussions
Replies: 1 comment 1 reply
-
Let's split the |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Per #453 there are two "categories" for the variants of
StageError
: fatal and non-fatal.Fatal errors stop the pipeline completely because they are assumed to be irrecoverable (e.g. db corruption), and non-fatal errors result in the pipeline retrying the stage again.
Currently, the only fatal variants in
StageError
are database related. There is one catch-all variant calledStageError::Internal
and it is unclear if this should be fatal or not: stages may want custom errors for informational purposes that are not fatal, but some errors from e.g. the standard library might be fatal (currently I don't think any stage emit errors from the standard library).Beta Was this translation helpful? Give feedback.
All reactions