Should reth return SYNCING for FCU when hooks are running? #8298
ImTei
started this conversation in
Technical discussions
Replies: 1 comment
-
@joshieDo , you have been working on this, right? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
There are several open issues(#7500) regarding op-reth sync.
As I understand, here's how this issue happens:
According to the Ethereum engine API specs, the condition of SYNCING is like this:
And also the spec said:
Skipping FCU due to running hooks seems to be
errors unrelated to the normal processing flow of the method
. So I think it should return an error object instead of SYNCING, to make op-node can handle it as a temporary error.What do you think? I'm new to reth code so I may be wrong here, if so please let me know!
Beta Was this translation helpful? Give feedback.
All reactions