fix: make inserted blocks part of fcu canonical #20164
Open
+109
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will mitigate suboptimal behaviour when we're trying to close the gap after transitioning from backfill to live sync.
previously this would only attempt to make the chain canonical if we have
[canonicalhead +1,..fcu.head]executed, which can be over 2 epochs of blocks and be an issue performance wise.this will now attempt to also make the finalized block, safe block canonical, because we can assume those are definitely part of the canonical chain.
this should restrict it to 32 blocks at most