fix(js-tracer): more fixes (#365)

Ref paradigmxyz/reth#18904
Closes #364

Changes js objects to be created via
`JsObject::with_object_proto(ctx.intrinsics())` instead of
`JsObject::default()` as suggested in
boa-dev/boa#4460 (comment) thus
making sure helpers like `hasOwnProperty` are accessible.

Changes `JsValue -> f64` conversion to happen via `to_numeric_number` so
that bigints can also be used as input values for `slice` functions

Author: klkvr

src/tracing/js/bindings.rs

@@ -199,7 +199,7 @@ impl StepLog {
             error,
             contract,
         } = self;
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
 
         // fields
         let op = op.into_js_object(ctx)?;
@@ -252,7 +252,7 @@ impl MemoryRef {
     }
 
     pub(crate) fn into_js_object(self, ctx: &mut Context) -> JsResult<JsObject> {
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
         let len = self.len();
 
         let length = FunctionObjectBuilder::new(
@@ -269,8 +269,8 @@ impl MemoryRef {
             ctx.realm(),
             NativeFunction::from_copy_closure_with_captures(
                 move |_this, args, memory, ctx| {
-                    let start = args.get_or_undefined(0).to_number(ctx)?;
-                    let end = args.get_or_undefined(1).to_number(ctx)?;
+                    let start = args.get_or_undefined(0).to_numeric_number(ctx)?;
+                    let end = args.get_or_undefined(1).to_numeric_number(ctx)?;
                     if end < start || start < 0. || (end as usize) > memory.len() {
                         return Err(JsError::from_native(JsNativeError::typ().with_message(
                             format!(
@@ -298,7 +298,7 @@ impl MemoryRef {
             ctx.realm(),
             NativeFunction::from_copy_closure_with_captures(
                 move |_this, args, memory, ctx| {
-                    let offset_f64 = args.get_or_undefined(0).to_number(ctx)?;
+                    let offset_f64 = args.get_or_undefined(0).to_numeric_number(ctx)?;
                     let len = memory.len();
                     let offset = offset_f64 as usize;
                     if len < offset + 32 || offset_f64 < 0. {
@@ -379,7 +379,7 @@ pub(crate) struct OpObj(pub(crate) u8);
 
 impl OpObj {
     pub(crate) fn into_js_object(self, context: &mut Context) -> JsResult<JsObject> {
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(context.intrinsics());
         let value = self.0;
         let is_push = (PUSH0..=PUSH32).contains(&value);
 
@@ -457,7 +457,7 @@ impl StackRef {
     }
 
     pub(crate) fn into_js_object(self, context: &mut Context) -> JsResult<JsObject> {
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(context.intrinsics());
         let len = self.0.with_inner(|stack| stack.len()).unwrap_or_default();
         let length = FunctionObjectBuilder::new(
             context.realm(),
@@ -471,7 +471,7 @@ impl StackRef {
             context.realm(),
             NativeFunction::from_copy_closure_with_captures(
                 move |_this, args, stack, ctx| {
-                    let idx_f64 = args.get_or_undefined(0).to_number(ctx)?;
+                    let idx_f64 = args.get_or_undefined(0).to_numeric_number(ctx)?;
                     let idx = idx_f64 as usize;
                     if len <= idx || idx_f64 < 0. {
                         return Err(JsError::from_native(JsNativeError::typ().with_message(
@@ -513,7 +513,7 @@ impl Contract {
     /// Caution: this expects a global property `bigint` to be present.
     pub(crate) fn into_js_object(self, ctx: &mut Context) -> JsResult<JsObject> {
         let Self { caller, contract, value, input } = self;
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
 
         let get_caller = FunctionObjectBuilder::new(
             ctx.realm(),
@@ -570,7 +570,7 @@ pub(crate) struct FrameResult {
 impl FrameResult {
     pub(crate) fn into_js_object(self, ctx: &mut Context) -> JsResult<JsObject> {
         let Self { gas_used, output, error } = self;
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
 
         let output = to_uint8_array_value(output, ctx)?;
         let get_output = FunctionObjectBuilder::new(
@@ -605,7 +605,7 @@ pub(crate) struct CallFrame {
 impl CallFrame {
     pub(crate) fn into_js_object(self, ctx: &mut Context) -> JsResult<JsObject> {
         let Self { contract: Contract { caller, contract, value, input }, kind, gas } = self;
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
 
         let get_from = FunctionObjectBuilder::new(
             ctx.realm(),
@@ -708,7 +708,7 @@ impl JsEvmContext {
             transaction_ctx,
             error,
         } = self;
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
 
         // add properties
 
@@ -849,7 +849,7 @@ impl EvmDbRef {
     }
 
     pub(crate) fn into_js_object(self, ctx: &mut Context) -> JsResult<JsObject> {
-        let obj = JsObject::default();
+        let obj = JsObject::with_object_proto(ctx.intrinsics());
         let exists = FunctionObjectBuilder::new(
             ctx.realm(),
             NativeFunction::from_copy_closure_with_captures(

src/tracing/js/builtins.rs

@@ -313,8 +313,8 @@ pub(crate) fn slice(_: &JsValue, args: &[JsValue], ctx: &mut Context) -> JsResul
     let val = args.get_or_undefined(0).clone();
 
     let buf = bytes_from_value(val, ctx)?;
-    let start = args.get_or_undefined(1).to_number(ctx)? as usize;
-    let end = args.get_or_undefined(2).to_number(ctx)? as usize;
+    let start = args.get_or_undefined(1).to_numeric_number(ctx)? as usize;
+    let end = args.get_or_undefined(2).to_numeric_number(ctx)? as usize;
 
     if start > end || end > buf.len() {
         Err(JsError::from_native(JsNativeError::error().with_message(format!(

src/tracing/js/mod.rs

@@ -1022,4 +1022,34 @@ mod tests {
         let res = run_trace(code, Some(bytes!("0x00")), true);
         assert_eq!(res, json!([true, true, false]));
     }
+
+    #[test]
+    fn test_has_own_property() {
+        let code = r#"{
+            res: [],
+            step: function(log) {
+                this.res.push(log.hasOwnProperty("stack"));
+            },
+            fault: function() {},
+            result: function() { return this.res }
+        }"#;
+        let res = run_trace(code, Some(bytes!("0x00")), true);
+        assert_eq!(res, json!([true]));
+    }
+
+    #[test]
+    fn test_slice_with_stack_values() {
+        let code = r#"{
+            res: [],
+            step: function(log) {
+                if ((log.stack.length() > 0) && log.memory.length() >= log.stack.peek(0)) {
+                    this.res.push(log.memory.slice(0, log.stack.peek(0)));
+                }
+            },
+            fault: function() {},
+            result: function() { return this.res }
+        }"#;
+        let res = run_trace(code, Some(bytes!("0x5F5F52600100")), true);
+        assert_eq!(res, json!([json!({}), json!({}), json!({"0": 0})]));
+    }
 }