Extract frame trace events construction logic (facebook#54675)

Summary:
Pull Request resolved: facebook#54675

# Changelog: [Internal]

Extracing the spec for frames events to a new class `TraceEventGenerator`.

This is a preparation for moving frames events to Host.

Reviewed By: sbuggay

Differential Revision: D87373809

fbshipit-source-id: 56538a8fae7d41a7117cd8445b15630ac7f50672

Author: hoxyq

packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

@@ -7,6 +7,7 @@
 
 #include "PerformanceTracer.h"
 #include "Timing.h"
+#include "TraceEventGenerator.h"
 #include "TraceEventSerializer.h"
 #include "TracingCategory.h"
 
@@ -794,20 +795,13 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
                 });
           },
           [&](PerformanceTracerSetLayerTreeIdEvent&& event) {
-            folly::dynamic data = folly::dynamic::object("frame", event.frame)(
-                "layerTreeId", event.layerTreeId);
-
             events.emplace_back(
-                TraceEvent{
-                    .name = "SetLayerTreeId",
-                    .cat = {Category::Timeline},
-                    .ph = 'I',
-                    .ts = event.start,
-                    .pid = processId_,
-                    .s = 't',
-                    .tid = event.threadId,
-                    .args = folly::dynamic::object("data", std::move(data)),
-                });
+                TraceEventGenerator::createSetLayerTreeIdEvent(
+                    std::move(event.frame),
+                    event.layerTreeId,
+                    processId_,
+                    event.threadId,
+                    event.start));
           },
           [&](PerformanceTracerFrameBeginDrawEvent&& event) {
             folly::dynamic data = folly::dynamic::object(

packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceEventGenerator.cpp

@@ -0,0 +1,80 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "TraceEventGenerator.h"
+#include "TracingCategory.h"
+
+namespace facebook::react::jsinspector_modern::tracing {
+
+/* static */ TraceEvent TraceEventGenerator::createSetLayerTreeIdEvent(
+    std::string frame,
+    int layerTreeId,
+    ProcessId processId,
+    ThreadId threadId,
+    HighResTimeStamp timestamp) {
+  folly::dynamic data = folly::dynamic::object("frame", std::move(frame))(
+      "layerTreeId", layerTreeId);
+
+  return TraceEvent{
+      .name = "SetLayerTreeId",
+      .cat = {Category::Timeline},
+      .ph = 'I',
+      .ts = timestamp,
+      .pid = processId,
+      .s = 't',
+      .tid = threadId,
+      .args = folly::dynamic::object("data", std::move(data)),
+  };
+}
+
+/* static */ std::tuple<TraceEvent, TraceEvent, TraceEvent>
+TraceEventGenerator::createFrameTimingsEvents(
+    uint64_t sequenceId,
+    int layerTreeId,
+    HighResTimeStamp beginDrawingTimestamp,
+    HighResTimeStamp commitTimestamp,
+    HighResTimeStamp endDrawingTimestamp,
+    ProcessId processId,
+    ThreadId threadId) {
+  folly::dynamic args = folly::dynamic::object("frameSeqId", sequenceId)(
+      "layerTreeId", layerTreeId);
+
+  auto beginEvent = TraceEvent{
+      .name = "BeginFrame",
+      .cat = {Category::Timeline},
+      .ph = 'I',
+      .ts = beginDrawingTimestamp,
+      .pid = processId,
+      .s = 't',
+      .tid = threadId,
+      .args = args,
+  };
+  auto commitEvent = TraceEvent{
+      .name = "Commit",
+      .cat = {Category::Timeline},
+      .ph = 'I',
+      .ts = commitTimestamp,
+      .pid = processId,
+      .s = 't',
+      .tid = threadId,
+      .args = args,
+  };
+  auto drawEvent = TraceEvent{
+      .name = "DrawFrame",
+      .cat = {Category::Timeline},
+      .ph = 'I',
+      .ts = endDrawingTimestamp,
+      .pid = processId,
+      .s = 't',
+      .tid = threadId,
+      .args = args,
+  };
+
+  return {std::move(beginEvent), std::move(commitEvent), std::move(drawEvent)};
+}
+
+}; // namespace facebook::react::jsinspector_modern::tracing

packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceEventGenerator.h

@@ -0,0 +1,47 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include "TraceEvent.h"
+
+#include <react/timing/primitives.h>
+
+#include <tuple>
+
+namespace facebook::react::jsinspector_modern::tracing {
+
+/**
+ * This class encapsulates the logic for generating canonical trace events that will be serialized and sent as part of
+ * Tracing.dataCollected CDP message.
+ */
+class TraceEventGenerator {
+ public:
+  /**
+   * Creates canonical "SetLayerTreeId" trace event.
+   */
+  static TraceEvent createSetLayerTreeIdEvent(
+      std::string frame,
+      int layerTreeId,
+      ProcessId processId,
+      ThreadId threadId,
+      HighResTimeStamp timestamp);
+
+  /**
+   * Creates canonical "BeginFrame", "Commit", "DrawFrame" trace events.
+   */
+  static std::tuple<TraceEvent, TraceEvent, TraceEvent> createFrameTimingsEvents(
+      uint64_t sequenceId,
+      int layerTreeId,
+      HighResTimeStamp beginDrawingTimestamp,
+      HighResTimeStamp commitTimestamp,
+      HighResTimeStamp endDrawingTimestamp,
+      ProcessId processId,
+      ThreadId threadId);
+};
+
+}; // namespace facebook::react::jsinspector_modern::tracing