Keep tracing time window on TraceRecordingState (facebook#54673)

Summary:
Pull Request resolved: facebook#54673

# Changelog: [Internal]

`HostTargetTraceRecording` will receive the tracing window size as a parameter and will propagate it to `TraceRecordingState`.

This will make sure that all Tracing Agents actually aware of the window size.

For example, once we add Frames to Host layer, it should use the same window size, as `PerformanceTracer`, which is initialized in `InstanceTracingAgent`.

Reviewed By: sbuggay

Differential Revision: D87782664

fbshipit-source-id: 58203065d68ac898adc785317ec2cb792efd13dc

Author: hoxyq

packages/react-native/ReactCommon/jsinspector-modern/HostTargetTraceRecording.cpp

@@ -15,10 +15,12 @@ namespace facebook::react::jsinspector_modern {
 HostTargetTraceRecording::HostTargetTraceRecording(
     HostTarget& hostTarget,
     tracing::Mode tracingMode,
-    std::set<tracing::Category> enabledCategories)
+    std::set<tracing::Category> enabledCategories,
+    std::optional<HighResDuration> windowSize)
     : hostTarget_(hostTarget),
       tracingMode_(tracingMode),
-      enabledCategories_(std::move(enabledCategories)) {}
+      enabledCategories_(std::move(enabledCategories)),
+      windowSize_(windowSize) {}
 
 void HostTargetTraceRecording::setTracedInstance(
     InstanceTarget* instanceTarget) {
@@ -35,10 +37,8 @@ void HostTargetTraceRecording::start() {
       "Tracing Agent for the HostTarget was already initialized.");
 
   startTime_ = HighResTimeStamp::now();
-  state_ = tracing::TraceRecordingState{
-      .mode = tracingMode_,
-      .enabledCategories = enabledCategories_,
-  };
+  state_ = tracing::TraceRecordingState(
+      tracingMode_, enabledCategories_, windowSize_);
   hostTracingAgent_ = hostTarget_.createTracingAgent(*state_);
 }
 

packages/react-native/ReactCommon/jsinspector-modern/HostTargetTraceRecording.h

@@ -14,6 +14,7 @@
 #include <jsinspector-modern/tracing/HostTracingProfile.h>
 #include <jsinspector-modern/tracing/TraceRecordingState.h>
 #include <jsinspector-modern/tracing/TracingCategory.h>
+#include <react/timing/primitives.h>
 
 #include <optional>
 #include <set>
@@ -31,10 +32,11 @@ namespace facebook::react::jsinspector_modern {
  */
 class HostTargetTraceRecording {
  public:
-  explicit HostTargetTraceRecording(
+  HostTargetTraceRecording(
       HostTarget &hostTarget,
       tracing::Mode tracingMode,
-      std::set<tracing::Category> enabledCategories);
+      std::set<tracing::Category> enabledCategories,
+      std::optional<HighResDuration> windowSize = std::nullopt);
 
   inline bool isBackgroundInitiated() const
   {
@@ -97,6 +99,11 @@ class HostTargetTraceRecording {
    * The list of categories that are enabled for this recording.
    */
   std::set<tracing::Category> enabledCategories_;
+
+  /**
+   * The size of the time window for this recording.
+   */
+  std::optional<HighResDuration> windowSize_;
 };
 
 } // namespace facebook::react::jsinspector_modern

packages/react-native/ReactCommon/jsinspector-modern/HostTargetTracing.cpp

@@ -10,6 +10,15 @@
 
 namespace facebook::react::jsinspector_modern {
 
+namespace {
+
+// The size of the timeline for the trace recording that happened in the
+// background.
+constexpr HighResDuration kBackgroundTraceWindowSize =
+    HighResDuration::fromMilliseconds(20000);
+
+} // namespace
+
 bool HostTargetController::startTracing(
     tracing::Mode tracingMode,
     std::set<tracing::Category> enabledCategories) {
@@ -39,11 +48,14 @@ bool HostTarget::startTracing(
     }
   }
 
+  auto timeWindow = tracingMode == tracing::Mode::Background
+      ? std::make_optional(kBackgroundTraceWindowSize)
+      : std::nullopt;
   auto screenshotsCategoryEnabled =
       enabledCategories.contains(tracing::Category::Screenshot);
 
   traceRecording_ = std::make_unique<HostTargetTraceRecording>(
-      *this, tracingMode, std::move(enabledCategories));
+      *this, tracingMode, std::move(enabledCategories), timeWindow);
   traceRecording_->setTracedInstance(currentInstance_.get());
   traceRecording_->start();
 

packages/react-native/ReactCommon/jsinspector-modern/InstanceAgent.cpp

@@ -15,15 +15,6 @@
 
 namespace facebook::react::jsinspector_modern {
 
-namespace {
-
-// The size of the timeline for the trace recording that happened in the
-// background.
-constexpr HighResDuration kBackgroundTracePerformanceTracerWindowSize =
-    HighResDuration::fromMilliseconds(20000);
-
-} // namespace
-
 InstanceAgent::InstanceAgent(
     FrontendChannel frontendChannel,
     InstanceTarget& target,
@@ -171,8 +162,8 @@ void InstanceAgent::maybeSendPendingConsoleMessages() {
 InstanceTracingAgent::InstanceTracingAgent(tracing::TraceRecordingState& state)
     : tracing::TargetTracingAgent(state) {
   auto& performanceTracer = tracing::PerformanceTracer::getInstance();
-  if (state.mode == tracing::Mode::Background) {
-    performanceTracer.startTracing(kBackgroundTracePerformanceTracerWindowSize);
+  if (state.windowSize) {
+    performanceTracer.startTracing(*state.windowSize);
   } else {
     performanceTracer.startTracing();
   }

packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceRecordingState.h

@@ -23,6 +23,14 @@ namespace facebook::react::jsinspector_modern::tracing {
  * Shared with Tracing Agents, which could use it to stash the corresponding target profiles during reloads.
  */
 struct TraceRecordingState {
+  TraceRecordingState(
+      tracing::Mode tracingMode,
+      std::set<tracing::Category> enabledCategories,
+      std::optional<HighResDuration> windowSize = std::nullopt)
+      : mode(tracingMode), enabledCategories(std::move(enabledCategories)), windowSize(windowSize)
+  {
+  }
+
   // The mode of this Trace Recording.
   tracing::Mode mode;
 
@@ -34,6 +42,9 @@ struct TraceRecordingState {
 
   // The list of categories that are enabled for this recording.
   std::set<tracing::Category> enabledCategories;
+
+  // The size of the time window for this recording.
+  std::optional<HighResDuration> windowSize;
 };
 
 } // namespace facebook::react::jsinspector_modern::tracing