fix: dont allow duplicated family requests

Author: t7ru

src/commands/family.ts

@@ -287,6 +287,20 @@ export async function execute(
           return;
         }
 
+        const existingMarriage = await FamilyManager.getRelationship(
+          interaction.user.id,
+          targetUser.id,
+          "spouse",
+        );
+
+        if (existingMarriage) {
+          await interaction.reply({
+            content: `**YOU ARE ALREADY MARRIED TO ${targetUser.tag.toUpperCase()}!**`,
+            flags: MessageFlags.Ephemeral,
+          });
+          return;
+        }
+
         const hasExistingRelationship = await FamilyManager.hasRelationship(
           interaction.user.id,
           targetUser.id,
@@ -688,6 +702,20 @@ export async function execute(
           return;
         }
 
+        const existingAdoption = await FamilyManager.getRelationship(
+          interaction.user.id,
+          targetUser.id,
+          "parent",
+        );
+
+        if (existingAdoption) {
+          await interaction.reply({
+            content: `**YOU HAVE ALREADY ADOPTED ${targetUser.tag.toUpperCase()}!**`,
+            flags: MessageFlags.Ephemeral,
+          });
+          return;
+        }
+
         const hasExistingRelationship = await FamilyManager.hasRelationship(
           interaction.user.id,
           targetUser.id,
@@ -1066,6 +1094,20 @@ export async function execute(
           return;
         }
 
+        const existingSibling = await FamilyManager.getRelationship(
+          interaction.user.id,
+          targetUser.id,
+          "sibling",
+        );
+
+        if (existingSibling) {
+          await interaction.reply({
+            content: `**YOU ARE ALREADY SIBLINGS WITH ${targetUser.tag.toUpperCase()}!**`,
+            flags: MessageFlags.Ephemeral,
+          });
+          return;
+        }
+
         const hasExistingRelationship = await FamilyManager.hasRelationship(
           interaction.user.id,
           targetUser.id,

src/utils/familyManager.ts

@@ -136,33 +136,46 @@ export class FamilyManager {
     guildId: string,
   ): Promise<void> {
     const data = await this.loadData();
+    const now = new Date().toISOString();
+
+    const hasExact = (
+      a: string,
+      b: string,
+      t: FamilyRelationship["relationshipType"],
+      g: string,
+    ) =>
+      data.relationships.some(
+        (rel) =>
+          rel.userId === a &&
+          rel.relatedUserId === b &&
+          rel.relationshipType === t &&
+          rel.guildId === g,
+      );
 
-    data.relationships.push({
-      userId,
-      relatedUserId,
-      relationshipType: type,
-      establishedAt: new Date().toISOString(),
-      guildId,
-    });
+    const addExact = (
+      a: string,
+      b: string,
+      t: FamilyRelationship["relationshipType"],
+    ) => {
+      if (hasExact(a, b, t, guildId)) return;
 
-    if (type === "spouse" || type === "sibling") {
       data.relationships.push({
-        userId: relatedUserId,
-        relatedUserId: userId,
-        relationshipType: type,
-        establishedAt: new Date().toISOString(),
+        userId: a,
+        relatedUserId: b,
+        relationshipType: t,
+        establishedAt: now,
         guildId,
       });
+    };
+
+    addExact(userId, relatedUserId, type);
+
+    if (type === "spouse" || type === "sibling") {
+      addExact(relatedUserId, userId, type);
     }
 
     if (type === "parent") {
-      data.relationships.push({
-        userId: relatedUserId,
-        relatedUserId: userId,
-        relationshipType: "child",
-        establishedAt: new Date().toISOString(),
-        guildId,
-      });
+      addExact(relatedUserId, userId, "child");
     }
 
     await this.saveData(data);