Merge pull request #1 from ojhaujjwal/constructor-domain

constructor domain

Author: paragonie-scott

src/Cookie.php

@@ -87,14 +87,15 @@ final class Cookie
      *
      * @param string $name The name of the cookie which is also the key for
      *                     future accesses via `$_COOKIE[...]`.
+     * @param string $domain The domain that the cookie will be valid for (including all subdomains)
      */
-    public function __construct(string $name)
+    public function __construct(string $name, string $domain = null)
     {
         $this->name = $name;
         $this->value = null;
         $this->expiryTime = 0;
         $this->path = '/';
-        $this->domain = self::normalizeDomain($_SERVER['HTTP_HOST']);
+        $this->setDomain(self::normalizeDomain($domain ?? $_SERVER['HTTP_HOST']));        
         $this->httpOnly = true;
         $this->secureOnly = false;
         $this->sameSiteRestriction = self::SAME_SITE_RESTRICTION_STRICT;

tests/index.php

@@ -106,7 +106,7 @@
 testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('.localhost'), 'Set-Cookie: key=value; path=/; httponly; SameSite=Lax');
 testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('127.0.0.1'), 'Set-Cookie: key=value; path=/; httponly; SameSite=Lax');
 testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('.local'), 'Set-Cookie: key=value; path=/; httponly; SameSite=Lax');
-testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('example.com'), 'Set-Cookie: key=value; path=/; domain=.example.com; httponly; SameSite=Lax');
+testEqual((new \ParagonIE\Cookie\Cookie('key', 'example.com'))->setValue('value'), 'Set-Cookie: key=value; path=/; domain=.example.com; httponly; SameSite=Lax');
 testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('.example.com'), 'Set-Cookie: key=value; path=/; domain=.example.com; httponly; SameSite=Lax');
 testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('www.example.com'), 'Set-Cookie: key=value; path=/; domain=.example.com; httponly; SameSite=Lax');
 testEqual((new \ParagonIE\Cookie\Cookie('key'))->setValue('value')->setDomain('.www.example.com'), 'Set-Cookie: key=value; path=/; domain=.example.com; httponly; SameSite=Lax');