Skip to content

Commit 032c9f7

Browse files
author
Kenneth Glassey
committed
Sanity check for delete page function
Page collection uses one-based indexing, so disallow n = 0. If n > page, nothing will be removed, but the page property will be messed up.
1 parent 33c5ec8 commit 032c9f7

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

jspdf.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -713,13 +713,15 @@ var jsPDF = (function(global) {
713713
events.publish('addPage', { pageNumber : page });
714714
},
715715
_deletePage = function( n ) {
716-
pages.splice(n, 1);
717-
pagedim.splice(n, 1);
718-
page--;
719-
if (currentPage > page){
720-
currentPage = page;
716+
if (n > 0 && n <= page) {
717+
pages.splice(n, 1);
718+
pagedim.splice(n, 1);
719+
page--;
720+
if (currentPage > page){
721+
currentPage = page;
722+
}
723+
this.setPage(currentPage);
721724
}
722-
this.setPage(currentPage);
723725
},
724726
_setPage = function(n) {
725727
if (n > 0 && n <= page) {

0 commit comments

Comments
 (0)