Commit 1002184
committed
Fix critical bugs exposed by TypeScript conversion
- Fix pageNumber undefined in getPageInfoByObjId - declare variable before loop
- Fix len undefined in text function - declare variable in proper scope
- These bugs were masked in JavaScript but exposed by stricter TypeScript testing
- Reduced test failures from 110 to 25 (node tests)1 parent b71ec4e commit 1002184
15 files changed
+45
-33
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
3492 | 3492 | | |
3493 | 3493 | | |
3494 | 3494 | | |
3495 | | - | |
3496 | | - | |
| 3495 | + | |
| 3496 | + | |
| 3497 | + | |
| 3498 | + | |
3497 | 3499 | | |
3498 | 3500 | | |
3499 | 3501 | | |
| |||
3936 | 3938 | | |
3937 | 3939 | | |
3938 | 3940 | | |
| 3941 | + | |
3939 | 3942 | | |
3940 | 3943 | | |
3941 | 3944 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
3779 | 3779 | | |
3780 | 3780 | | |
3781 | 3781 | | |
3782 | | - | |
3783 | | - | |
| 3782 | + | |
| 3783 | + | |
| 3784 | + | |
| 3785 | + | |
3784 | 3786 | | |
3785 | 3787 | | |
3786 | 3788 | | |
| |||
4246 | 4248 | | |
4247 | 4249 | | |
4248 | 4250 | | |
| 4251 | + | |
4249 | 4252 | | |
4250 | 4253 | | |
4251 | 4254 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
3577 | 3577 | | |
3578 | 3578 | | |
3579 | 3579 | | |
3580 | | - | |
3581 | | - | |
| 3580 | + | |
| 3581 | + | |
| 3582 | + | |
| 3583 | + | |
3582 | 3584 | | |
3583 | 3585 | | |
3584 | 3586 | | |
| |||
4021 | 4023 | | |
4022 | 4024 | | |
4023 | 4025 | | |
| 4026 | + | |
4024 | 4027 | | |
4025 | 4028 | | |
4026 | 4029 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments