Commit 8b78db7
committed
Fix more variable scoping bugs exposed by TypeScript
- Fix rotationTransformationMatrix undefined in addimage module
- Fix fontSize and related variables undefined in context2d module
- Both caused by variables declared inside if blocks but used outside
- Test failures reduced from 25 to 7 (98% pass rate: 437/444 tests passing)1 parent 20a37b4 commit 8b78db7
File tree
16 files changed
+63
-50
lines changed- dist
- src/modules
16 files changed
+63
-50
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
8765 | 8765 | | |
8766 | 8766 | | |
8767 | 8767 | | |
| 8768 | + | |
8768 | 8769 | | |
8769 | 8770 | | |
8770 | 8771 | | |
| |||
8773 | 8774 | | |
8774 | 8775 | | |
8775 | 8776 | | |
8776 | | - | |
| 8777 | + | |
8777 | 8778 | | |
8778 | 8779 | | |
8779 | 8780 | | |
| |||
11204 | 11205 | | |
11205 | 11206 | | |
11206 | 11207 | | |
| 11208 | + | |
11207 | 11209 | | |
11208 | | - | |
| 11210 | + | |
11209 | 11211 | | |
11210 | | - | |
11211 | | - | |
| 11212 | + | |
| 11213 | + | |
11212 | 11214 | | |
11213 | | - | |
| 11215 | + | |
11214 | 11216 | | |
11215 | 11217 | | |
11216 | 11218 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
9487 | 9487 | | |
9488 | 9488 | | |
9489 | 9489 | | |
| 9490 | + | |
9490 | 9491 | | |
9491 | 9492 | | |
9492 | 9493 | | |
| |||
9495 | 9496 | | |
9496 | 9497 | | |
9497 | 9498 | | |
9498 | | - | |
| 9499 | + | |
9499 | 9500 | | |
9500 | 9501 | | |
9501 | 9502 | | |
| |||
12001 | 12002 | | |
12002 | 12003 | | |
12003 | 12004 | | |
| 12005 | + | |
12004 | 12006 | | |
12005 | | - | |
| 12007 | + | |
12006 | 12008 | | |
12007 | | - | |
12008 | | - | |
| 12009 | + | |
| 12010 | + | |
12009 | 12011 | | |
12010 | | - | |
| 12012 | + | |
12011 | 12013 | | |
12012 | 12014 | | |
12013 | 12015 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
8850 | 8850 | | |
8851 | 8851 | | |
8852 | 8852 | | |
| 8853 | + | |
8853 | 8854 | | |
8854 | 8855 | | |
8855 | 8856 | | |
| |||
8858 | 8859 | | |
8859 | 8860 | | |
8860 | 8861 | | |
8861 | | - | |
| 8862 | + | |
8862 | 8863 | | |
8863 | 8864 | | |
8864 | 8865 | | |
| |||
11289 | 11290 | | |
11290 | 11291 | | |
11291 | 11292 | | |
| 11293 | + | |
11292 | 11294 | | |
11293 | | - | |
| 11295 | + | |
11294 | 11296 | | |
11295 | | - | |
11296 | | - | |
| 11297 | + | |
| 11298 | + | |
11297 | 11299 | | |
11298 | | - | |
| 11300 | + | |
11299 | 11301 | | |
11300 | 11302 | | |
11301 | 11303 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments