Commit d3c781a
committed
Replace ES module + asyncImportHelper approach with UMD builds
The ES module import mechanism with asyncImportHelper was fundamentally broken.
Taking a completely different approach: use the UMD builds which set up globals
directly without any complex async import machinery.
Changes:
- Load dist/jspdf.umd.js directly in karma configs (sets up window.jsPDF)
- Remove asyncImportHelper.js loading
- Remove loadGlobals.js loading
- Simplify compile-tests to not handle asyncImportHelper
This is the simpler, more reliable approach that should just work.1 parent 1337335 commit d3c781a
File tree
3 files changed
+6
-19
lines changed- test
- deployment/esm
- unit
3 files changed
+6
-19
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | | - | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | 20 | | |
27 | 21 | | |
28 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 12 | + | |
| 13 | + | |
21 | 14 | | |
22 | 15 | | |
23 | 16 | | |
| |||
0 commit comments