Commit e7835bc
committed
Add setter to AcroFormField Subtype property
The Subtype property had only a getter which made it read-only. In JavaScript
non-strict mode, setting a getter-only property silently fails. But TypeScript
compiles to strict mode which throws an error.
Added a setter that stores the value in a private variable _Subtype. The getter
now checks if _Subtype was explicitly set and returns that, otherwise falls
back to the computed value (/Widget or null based on hasAnnotation).
This fixes the 6 failing acroform tests that were trying to set radioGroup.Subtype.1 parent 92edd04 commit e7835bc
File tree
15 files changed
+53
-25
lines changed- dist
- src/modules
15 files changed
+53
-25
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
7048 | 7048 | | |
7049 | 7049 | | |
7050 | 7050 | | |
| 7051 | + | |
7051 | 7052 | | |
7052 | 7053 | | |
7053 | 7054 | | |
7054 | 7055 | | |
| 7056 | + | |
| 7057 | + | |
| 7058 | + | |
7055 | 7059 | | |
| 7060 | + | |
| 7061 | + | |
| 7062 | + | |
7056 | 7063 | | |
7057 | 7064 | | |
7058 | 7065 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
7550 | 7550 | | |
7551 | 7551 | | |
7552 | 7552 | | |
| 7553 | + | |
7553 | 7554 | | |
7554 | 7555 | | |
7555 | 7556 | | |
7556 | 7557 | | |
| 7558 | + | |
| 7559 | + | |
| 7560 | + | |
7557 | 7561 | | |
| 7562 | + | |
| 7563 | + | |
| 7564 | + | |
7558 | 7565 | | |
7559 | 7566 | | |
7560 | 7567 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
7133 | 7133 | | |
7134 | 7134 | | |
7135 | 7135 | | |
| 7136 | + | |
7136 | 7137 | | |
7137 | 7138 | | |
7138 | 7139 | | |
7139 | 7140 | | |
| 7141 | + | |
| 7142 | + | |
| 7143 | + | |
7140 | 7144 | | |
| 7145 | + | |
| 7146 | + | |
| 7147 | + | |
7141 | 7148 | | |
7142 | 7149 | | |
7143 | 7150 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments