From f41a11f8d67e97e8d2e357cd424f515ab0d40fd8 Mon Sep 17 00:00:00 2001 From: Lukas Hollaender Date: Wed, 25 Sep 2024 14:26:16 +0200 Subject: [PATCH 1/2] update action dependency versions --- .github/workflows/continuous-integration.yml | 16 ++++++++-------- .github/workflows/npm-publish.yml | 4 ++-- .github/workflows/stale.yml | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 09056755f..47d6cbb99 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -8,9 +8,9 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install Node.js - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: node-version: 20 cache: npm @@ -34,9 +34,9 @@ jobs: name: Node.js ${{ matrix.node-version }} test steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: npm @@ -57,9 +57,9 @@ jobs: name: Typings tests (typescript@${{ matrix.ts-version.ts }}) steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install Node.js - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: node-version: 20 cache: npm @@ -77,9 +77,9 @@ jobs: name: Lint steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install Node.js - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: node-version: 20 cache: npm diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 8ff181147..6535c407c 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -11,8 +11,8 @@ jobs: publish-npm: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: 20 registry-url: https://registry.npmjs.org/ diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index d2741e435..f5551edf7 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/stale@v3 + - uses: actions/stale@v9 with: repo-token: ${{ secrets.GITHUB_TOKEN }} stale-issue-message: 'This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant.' From 3c968ce747230f05c4f0eb4ab7949efcc96c5e43 Mon Sep 17 00:00:00 2001 From: Lukas Hollaender Date: Wed, 25 Sep 2024 14:31:49 +0200 Subject: [PATCH 2/2] remove obsolete env re-define --- test/saucelabs/karma.conf.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/saucelabs/karma.conf.js b/test/saucelabs/karma.conf.js index c9400d553..c8c91458d 100644 --- a/test/saucelabs/karma.conf.js +++ b/test/saucelabs/karma.conf.js @@ -23,11 +23,6 @@ const browsers = { }; module.exports = config => { - // re-defining the env variables seems to fix the auth issue - // eslint-disable-next-line no-self-assign - process.env.SAUCE_USERNAME = process.env.SAUCE_USERNAME - // eslint-disable-next-line no-self-assign - process.env.SAUCE_ACCESS_KEY = process.env.SAUCE_ACCESS_KEY if ( !( process.env.SAUCE_USERNAME &&