remove profile and enforce global release property for java

Signed-off-by: Sam Spycher <[email protected]>

Author: samspycher

parsec-client-java/pom.xml

@@ -11,8 +11,6 @@
     <artifactId>parsec-client-java</artifactId>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
     </properties>
     <dependencies>
         <dependency>

parsec-interface-java/pom.xml

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
@@ -12,8 +11,6 @@
     <artifactId>parsec-interface-java</artifactId>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
     </properties>
 
     <dependencies>

parsec-jca-java-test/pom.xml

@@ -10,8 +10,6 @@
     <artifactId>parsec-jca-java-test</artifactId>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
     </properties>
 
     <dependencies>

parsec-jca-java/src/main/java/org/parallaxsecond/parsec/jce/provider/ParsecPublicKey.java

@@ -2,7 +2,6 @@
 
 import lombok.Builder;
 import lombok.Value;
-import sun.reflect.generics.reflectiveObjects.NotImplementedException;
 
 import java.security.PublicKey;
 
@@ -15,13 +14,14 @@ static ParsecPublicKey.ParsecPublicKeyImpl.ParsecPublicKeyImplBuilder builder()
 
     @Value
     @Builder
-    class ParsecPublicKeyImpl implements ParsecPublicKey{
+    class ParsecPublicKeyImpl implements ParsecPublicKey {
         String parsecName;
         String algorithm;
         String format;
+
         @Override
         public byte[] getEncoded() {
-            throw new NotImplementedException();
+            throw new UnsupportedOperationException("Not implemented");
         }
     }
 }

parsec-protobuf-java/pom.xml

@@ -14,8 +14,6 @@
         <protoc.version>3.18.0</protoc.version>
         <protobuf.version>3.19.6</protobuf.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
     </properties>
 
     <dependencies>

parsec-testcontainers/pom.xml

@@ -28,8 +28,6 @@
     </dependencies>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
         <containers.skip>false</containers.skip>
     </properties>
     <build>

pom.xml

@@ -8,13 +8,14 @@
     <version>1.0.0-SNAPSHOT</version>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
         <logback.version>1.3.15</logback.version>
         <lombok.version>1.18.36</lombok.version>
         <junit.jupiter.version>5.12.1</junit.jupiter.version>
         <slf4j.version>2.0.16</slf4j.version>
         <jpms.args></jpms.args>
+        <!-- Since compiler plugin version 3.13.0 you can use the release property also on JDK 8. 
+             The compiler plugin will convert it to source and target automatically. -->
+        <maven.compiler.release>8</maven.compiler.release>
     </properties>
     <dependencyManagement>
         <dependencies>
@@ -55,33 +56,6 @@
         <module>parsec-jca-java-test</module>
     </modules>
 
-    <profiles>
-        <profile>
-            <id>java1.8</id>
-            <activation>
-                <activeByDefault>false</activeByDefault>
-                <jdk>1.8</jdk>
-            </activation>
-            <build>
-                <pluginManagement>
-                    <plugins>
-                        <plugin>
-                            <groupId>org.apache.maven.plugins</groupId>
-                            <artifactId>maven-compiler-plugin</artifactId>
-                            <version>3.8.1</version>
-                            <configuration>
-                                <source>1.8</source>
-                                <target>1.8</target>
-                                <excludes>
-                                    <exclude>module-info.java</exclude>
-                                </excludes>
-                            </configuration>
-                        </plugin>
-                    </plugins>
-                </pluginManagement>
-            </build>
-        </profile>
-    </profiles>
     <build>
         <pluginManagement>
             <plugins>
@@ -110,6 +84,11 @@
                     <flattenMode>clean</flattenMode>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>3.14.0</version>
+            </plugin>
         </plugins>
     </build>
 </project>