Bump MSRV and fix clippy lints

Bumping MSRV to 1.60.0 as required for the picky-asn1 crate.

Also setting the MSRV for clippy and fixing some of the remaining
warnings. Some of the things clippy complains about for newer versions
of the compiler can be fixed/changed without losing support for older
compiler versions, but some features are incompatible. Since clippy is
now configured to understand the MSRV, there's also no need for some of
the `allow` attributes.

Signed-off-by: Ionut Mihalcea <[email protected]>

Author: ionut-arm

.clippy.toml

@@ -0,0 +1 @@
+msrv = "1.60.0"

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Build the container
         run: docker build -t ubuntucontainer tss-esapi/tests/ --file tss-esapi/tests/Dockerfile-ubuntu
       - name: Run the container
-        run: docker run -v $(pwd):/tmp/rust-tss-esapi -w /tmp/rust-tss-esapi/tss-esapi --env RUST_TOOLCHAIN_VERSION=1.57.0 ubuntucontainer /tmp/rust-tss-esapi/tss-esapi/tests/all-ubuntu.sh
+        run: docker run -v $(pwd):/tmp/rust-tss-esapi -w /tmp/rust-tss-esapi/tss-esapi --env RUST_TOOLCHAIN_VERSION=1.60.0 ubuntucontainer /tmp/rust-tss-esapi/tss-esapi/tests/all-ubuntu.sh
   # All in one job as I think it is a big overhead to build and run the Docker
   # container?
   tests-ubuntu:

tss-esapi-sys/build.rs

@@ -57,7 +57,6 @@ fn main() {
     }
 }
 
-#[allow(clippy::uninlined_format_args)]
 #[cfg(feature = "generate-bindings")]
 pub fn generate_from_system(esapi_out: PathBuf) {
     pkg_config::Config::new()

tss-esapi/Cargo.toml

@@ -24,8 +24,8 @@ regex = "1.3.9"
 zeroize = { version = "1.1.0", features = ["zeroize_derive"] }
 tss-esapi-sys = { path = "../tss-esapi-sys", version = "0.4.0" }
 oid = "0.2.1"
-picky-asn1 = "0.7.2"
-picky-asn1-x509 = "0.11.0"
+picky-asn1 = "0.5.0"
+picky-asn1-x509 = "0.7.1"
 
 [dev-dependencies]
 env_logger = "0.9.0"

tss-esapi/src/tcti_ldr.rs

@@ -166,7 +166,6 @@ impl TctiNameConf {
     }
 }
 
-#[allow(clippy::uninlined_format_args)]
 impl TryFrom<TctiNameConf> for CString {
     type Error = Error;