Makes NV context methods fail fast when missing session.

- Makes some of the context methods that deal with NV memory
  fail fast if a session has not been provided. Because according
  to the ESAPI specification some of the NV functions requires it.

Signed-off-by: Jesper Brynolf <[email protected]>

Author: Superhepper

tss-esapi/src/context/tpm_commands/non_volatile_storage.rs

@@ -22,6 +22,9 @@ impl Context {
     /// This method will instruct the TPM to reserve space for an NV index
     /// with the attributes defined in the provided parameters.
     ///
+    /// Please beware
+    /// that this method requires an authorization session handle to be present.
+    ///
     /// # Arguments
     /// * `nv_auth` - The [Provision] used for authorization.
     /// * `auth` - The authorization value.
@@ -106,7 +109,7 @@ impl Context {
                 Esys_NV_DefineSpace(
                     self.mut_context(),
                     AuthHandle::from(nv_auth).into(),
-                    self.optional_session_1(),
+                    self.required_session_1()?,
                     self.optional_session_2(),
                     self.optional_session_3(),
                     &auth.unwrap_or_default().into(),
@@ -130,6 +133,9 @@ impl Context {
     /// The method will instruct the TPM to remove a
     /// nv index.
     ///
+    /// Please beware that this method requires an authorization
+    /// session handle to be present.
+    ///
     /// # Arguments
     /// * `nv_auth` - The [Provision] used for authorization.
     /// * `nv_index_handle`- The [NvIndexHandle] associated with
@@ -207,7 +213,7 @@ impl Context {
                     self.mut_context(),
                     AuthHandle::from(nv_auth).into(),
                     nv_index_handle.into(),
-                    self.optional_session_1(),
+                    self.required_session_1()?,
                     self.optional_session_2(),
                     self.optional_session_3(),
                 )
@@ -339,6 +345,9 @@ impl Context {
     /// This method is used to write a value to
     /// the nv memory in the TPM.
     ///
+    /// Please beware that this method requires an authorization
+    /// session handle to be present.
+    ///
     /// # Arguments
     /// * `auth_handle` - Handle indicating the source of authorization value.
     /// * `nv_index_handle` - The [NvIndexHandle] associated with NV memory
@@ -432,7 +441,7 @@ impl Context {
                     self.mut_context(),
                     AuthHandle::from(auth_handle).into(),
                     nv_index_handle.into(),
-                    self.optional_session_1(),
+                    self.required_session_1()?,
                     self.optional_session_2(),
                     self.optional_session_3(),
                     &data.into(),
@@ -451,6 +460,9 @@ impl Context {
     /// This method is used to increment monotonic counter
     /// in the TPM.
     ///
+    /// Please beware that this method requires an authorization
+    /// session handle to be present.
+    ///
     /// # Arguments
     /// * `auth_handle` - Handle indicating the source of authorization value.
     /// * `nv_index_handle` - The [NvIndexHandle] associated with NV memory
@@ -535,7 +547,7 @@ impl Context {
                     self.mut_context(),
                     AuthHandle::from(auth_handle).into(),
                     nv_index_handle.into(),
-                    self.optional_session_1(),
+                    self.required_session_1()?,
                     self.optional_session_2(),
                     self.optional_session_3(),
                 )
@@ -555,6 +567,9 @@ impl Context {
     /// This method is used to read a value from an area in
     /// NV memory of the TPM.
     ///
+    /// Please beware that this method requires an authorization
+    /// session handle to be present.
+    ///
     /// # Arguments
     /// * `auth_handle` - Handle indicating the source of authorization value.
     /// * `nv_index_handle` - The [NvIndexHandle] associated with NV memory
@@ -656,7 +671,7 @@ impl Context {
                     self.mut_context(),
                     AuthHandle::from(auth_handle).into(),
                     nv_index_handle.into(),
-                    self.optional_session_1(),
+                    self.required_session_1()?,
                     self.optional_session_2(),
                     self.optional_session_3(),
                     size,