Skip to content

Conversation

@Superhepper
Copy link
Collaborator

@Superhepper Superhepper commented Nov 22, 2025

Fixes #467

@Superhepper Superhepper marked this pull request as ready for review November 23, 2025 21:09
##################
# Build examples #
##################
RUST_BACKTRACE=1 cargo build --examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be necessary as cargo test --examples needs to build them first anyway... 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but its nice to separate build errors from running the examples errors.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but its nice to separate build errors from running the examples errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I suggest using cargo check which shows build errors but doesn't waste time creating output artifacts (that we wouldn't need in CI anyway). 👋

Copy link
Collaborator Author

@Superhepper Superhepper Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that could be done.

Oh I just noted that the script does not start the tpm server ... But everything is green anyway ..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that could be done.

Oh I just noted that the script does not start the tom server ... But everything is green anyway ..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was way more complicated then I expected. The examples requires a resource broker.

@Superhepper Superhepper force-pushed the Ci-Examples branch 5 times, most recently from 5cfecc7 to e1fd179 Compare November 24, 2025 21:09
@Superhepper Superhepper marked this pull request as draft November 24, 2025 21:20
@Superhepper Superhepper force-pushed the Ci-Examples branch 17 times, most recently from f63f15e to 0186912 Compare November 30, 2025 08:03
@Superhepper Superhepper force-pushed the Ci-Examples branch 3 times, most recently from 6fd5b37 to 02fb471 Compare November 30, 2025 08:53
@Superhepper
Copy link
Collaborator Author

@Firstyear

When I try to add the certify example as well I get an error I have not yet figured out.

thread 'main' panicked at tss-esapi/examples/certify.rs:385:10:
called `Result::unwrap()` on an `Err` value: TssError(Tpm(FormatOne(TpmFormatOneResponseCode { error_number: PolicyFail, argument_number: Session(2) })))

Is that something you have seen as well and have had any experience with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI job for examples

2 participants