Skip to content

Commit b94216b

Browse files
author
Muhammad Ikhsan
committed
doc: tidy up
1 parent 10fedcd commit b94216b

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,20 @@ steinClient = gostein.New("http://yourstein.host/v1/storage/your-api-id", nil)
2323
```go
2424
...
2525
// Get all data
26-
data, err := steinClient.Get("sheet1", gostein.SearchParams{})
26+
data, err := steinClient.Get("sheet1", gostein.GetParams{})
2727

2828
// Get with offset and limit
29-
data, err := steinClient.Get("sheet1", gostein.SearchParams{Offset: 0, Limit: 10})
29+
data, err := steinClient.Get("sheet1", gostein.GetParams{Offset: 0, Limit: 10})
3030
...
3131
```
3232
The `data` will be in type of `[]map[string]interface{}`. To convert the data to specific struct, I recomended using [maptostructure package](https://github.com/mitchellh/mapstructure).
3333

3434
#### Search data
3535
Look up rows in a sheet by a specific value on column(s).
3636
```go
37-
data, err := steinClient.Get("sheet1", gostein.SearchParams{
37+
data, err := steinClient.Get("sheet1", gostein.GetParams{
3838
Limit: 10,
39-
Conditions: map[string]string{
39+
Search: map[string]string{
4040
"column_1": "value_column_1",
4141
"column_2": "value_column_2",
4242
}

stein.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ import (
99
"strings"
1010
)
1111

12-
type SearchParams struct {
13-
Offset int64
14-
Limit int64
15-
Conditions map[string]string
12+
type GetParams struct {
13+
Offset int64
14+
Limit int64
15+
Search map[string]string
1616
}
1717

1818
type AddResponse struct {
1919
UpdatedRange string `json:"updatedRange"`
2020
}
2121

2222
// builds the query string from the given params with query string escaping
23-
func (sp SearchParams) queryString() string {
23+
func (sp GetParams) queryString() string {
2424
queryString := ""
2525
if sp.Offset > 0 {
2626
queryString = queryString + fmt.Sprintf("offset=%d&", sp.Offset)
@@ -30,8 +30,8 @@ func (sp SearchParams) queryString() string {
3030
queryString = queryString + fmt.Sprintf("limit=%d&", sp.Limit)
3131
}
3232

33-
if len(sp.Conditions) > 0 {
34-
jsonSearch, err := json.Marshal(sp.Conditions)
33+
if len(sp.Search) > 0 {
34+
jsonSearch, err := json.Marshal(sp.Search)
3535
if err != nil {
3636
return ""
3737
}
@@ -46,7 +46,7 @@ func (sp SearchParams) queryString() string {
4646

4747
// Interface is the interface for the stein client
4848
type Interface interface {
49-
Get(sheet string, params SearchParams) ([]map[string]interface{}, error)
49+
Get(sheet string, params GetParams) ([]map[string]interface{}, error)
5050
Add(sheet string, rows ...map[string]interface{}) (AddResponse, error)
5151
}
5252

@@ -77,7 +77,7 @@ func (s *stein) decodeJSON(r io.Reader, v interface{}) error {
7777
}
7878

7979
// Get returns the rows in the given sheet
80-
func (s *stein) Get(sheet string, params SearchParams) ([]map[string]interface{}, error) {
80+
func (s *stein) Get(sheet string, params GetParams) ([]map[string]interface{}, error) {
8181
resource := fmt.Sprintf("%s/%s", s.url, removePrefix(sheet, "/"))
8282

8383
queryParams := params.queryString()

stein_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func Test_stein_Get(t *testing.T) {
2727
defer ts.Close()
2828

2929
sc := New(ts.URL, nil)
30-
resp, err := sc.Get("/sheetname", SearchParams{})
30+
resp, err := sc.Get("/sheetname", GetParams{})
3131
if err != nil {
3232
t.Errorf("Error: %v", err)
3333
}
@@ -47,7 +47,7 @@ func Test_stein_Get(t *testing.T) {
4747
defer ts.Close()
4848

4949
sc := New(ts.URL, nil)
50-
_, err := sc.Get("/sheetname", SearchParams{})
50+
_, err := sc.Get("/sheetname", GetParams{})
5151
assert.NotNil(t, err)
5252
if !errors.As(err, &ErrNot2XX{}) {
5353
t.Errorf("Expected ErrNot2XX, got %v", err)
@@ -65,7 +65,7 @@ func Test_stein_Get(t *testing.T) {
6565
defer ts.Close()
6666

6767
sc := New(ts.URL, nil)
68-
_, err := sc.Get("/sheetname", SearchParams{})
68+
_, err := sc.Get("/sheetname", GetParams{})
6969
assert.NotNil(t, err)
7070
if !errors.As(err, &ErrDecodeJSON{}) {
7171
t.Errorf("Expected ErrDecode, got %v", err)
@@ -75,10 +75,10 @@ func Test_stein_Get(t *testing.T) {
7575

7676
func TestSearchParams_queryString(t *testing.T) {
7777
t.Run("should return the correct query string", func(t *testing.T) {
78-
params := SearchParams{
78+
params := GetParams{
7979
Offset: 20,
8080
Limit: 10,
81-
Conditions: map[string]string{
81+
Search: map[string]string{
8282
"column_1": "value_column_1",
8383
"column_2": "value_column_2",
8484
},

0 commit comments

Comments
 (0)