Drop <testsuites> name attribute that doesn't exist in PHPUnit (#1042)

Slamdunk · web-flow · commit de06de1ae120 · 2025-10-24T09:20:53.000+02:00
* Regenerate fixtures from bare PHPUnit

* Drop `&lt;testsuites&gt;` name attribute that doesn't exist in PHPUnit
diff --git a/Makefile b/Makefile
@@ -87,3 +87,4 @@ regenerate-fixture-results: vendor
 	find test/fixtures/ -type f -name "*.xml" -print0 | xargs -0 sed -i 's#$(PWD)#.#g'
 	find test/fixtures/ -type f -name "*.xml" -print0 | xargs -0 sed -i 's#time="........"#time="1.234567"#g'
 	sed -i 's#name="./test/fixtures/common_results"#name=""#g' test/fixtures/common_results/combined.xml
+	sed -i 's#name="CLI Arguments"#name=""#g' test/fixtures/common_results/combined.xml
diff --git a/src/JUnit/Writer.php b/src/JUnit/Writer.php
@@ -23,7 +23,6 @@
 /** @internal */
 final readonly class Writer
 {
-    private const TESTSUITES_NAME = 'PHPUnit tests';
     private DOMDocument $document;
 
     public function __construct()
@@ -48,7 +47,6 @@ private function getXml(TestSuite $testSuite): string
     {
         $xmlTestsuites = $this->document->createElement('testsuites');
         $xmlTestsuites->appendChild($this->createSuiteNode($testSuite));
-        $xmlTestsuites->setAttribute('name', self::TESTSUITES_NAME);
         $this->document->appendChild($xmlTestsuites);
 
         $xml = $this->document->saveXML();
@@ -60,7 +58,7 @@ private function getXml(TestSuite $testSuite): string
     private function createSuiteNode(TestSuite $parentSuite): DOMElement
     {
         $suiteNode = $this->document->createElement('testsuite');
-        $suiteNode->setAttribute('name', $parentSuite->name !== self::TESTSUITES_NAME ? $parentSuite->name : '');
+        $suiteNode->setAttribute('name', $parentSuite->name);
         if ($parentSuite->file !== '') {
             $suiteNode->setAttribute('file', $parentSuite->file);
         }
diff --git a/test/fixtures/common_results/combined.xml b/test/fixtures/common_results/combined.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="" tests="7" assertions="3" errors="1" failures="1" skipped="2" time="1.234567">
     <testsuite name="ParaTest\Tests\fixtures\common_results\ErrorTest" file="./test/fixtures/common_results/ErrorTest.php" tests="1" assertions="0" errors="1" failures="0" skipped="0" time="1.234567">
       <testcase name="testError" file="./test/fixtures/common_results/ErrorTest.php" line="13" class="ParaTest\Tests\fixtures\common_results\ErrorTest" classname="ParaTest.Tests.fixtures.common_results.ErrorTest" assertions="0" time="1.234567">
diff --git a/test/fixtures/common_results/junit/ErrorTest.xml b/test/fixtures/common_results/junit/ErrorTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\ErrorTest" file="./test/fixtures/common_results/ErrorTest.php" tests="1" assertions="0" errors="1" failures="0" skipped="0" time="1.234567">
     <testcase name="testError" file="./test/fixtures/common_results/ErrorTest.php" line="13" class="ParaTest\Tests\fixtures\common_results\ErrorTest" classname="ParaTest.Tests.fixtures.common_results.ErrorTest" assertions="0" time="1.234567">
       <error type="RuntimeException">ParaTest\Tests\fixtures\common_results\ErrorTest::testError
diff --git a/test/fixtures/common_results/junit/FailureTest.xml b/test/fixtures/common_results/junit/FailureTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\FailureTest" file="./test/fixtures/common_results/FailureTest.php" tests="1" assertions="1" errors="0" failures="1" skipped="0" time="1.234567">
     <testcase name="testFailure" file="./test/fixtures/common_results/FailureTest.php" line="12" class="ParaTest\Tests\fixtures\common_results\FailureTest" classname="ParaTest.Tests.fixtures.common_results.FailureTest" assertions="1" time="1.234567">
       <failure type="PHPUnit\Framework\ExpectationFailedException">ParaTest\Tests\fixtures\common_results\FailureTest::testFailure
diff --git a/test/fixtures/common_results/junit/IncompleteTest.xml b/test/fixtures/common_results/junit/IncompleteTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\IncompleteTest" file="./test/fixtures/common_results/IncompleteTest.php" tests="1" assertions="0" errors="0" failures="0" skipped="1" time="1.234567">
     <testcase name="testIncomplete" file="./test/fixtures/common_results/IncompleteTest.php" line="12" class="ParaTest\Tests\fixtures\common_results\IncompleteTest" classname="ParaTest.Tests.fixtures.common_results.IncompleteTest" assertions="0" time="1.234567">
       <skipped/>
diff --git a/test/fixtures/common_results/junit/RiskyTest.xml b/test/fixtures/common_results/junit/RiskyTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\RiskyTest" file="./test/fixtures/common_results/RiskyTest.php" tests="1" assertions="0" errors="0" failures="0" skipped="0" time="1.234567">
     <testcase name="testRisky" file="./test/fixtures/common_results/RiskyTest.php" line="12" class="ParaTest\Tests\fixtures\common_results\RiskyTest" classname="ParaTest.Tests.fixtures.common_results.RiskyTest" assertions="0" time="1.234567"/>
   </testsuite>
diff --git a/test/fixtures/common_results/junit/SkippedTest.xml b/test/fixtures/common_results/junit/SkippedTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\SkippedTest" file="./test/fixtures/common_results/SkippedTest.php" tests="1" assertions="0" errors="0" failures="0" skipped="1" time="1.234567">
     <testcase name="testSkipped" file="./test/fixtures/common_results/SkippedTest.php" line="12" class="ParaTest\Tests\fixtures\common_results\SkippedTest" classname="ParaTest.Tests.fixtures.common_results.SkippedTest" assertions="0" time="1.234567">
       <skipped/>
diff --git a/test/fixtures/common_results/junit/SuccessTest.xml b/test/fixtures/common_results/junit/SuccessTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\SuccessTest" file="./test/fixtures/common_results/SuccessTest.php" tests="1" assertions="1" errors="0" failures="0" skipped="0" time="1.234567">
     <testcase name="testSuccess" file="./test/fixtures/common_results/SuccessTest.php" line="12" class="ParaTest\Tests\fixtures\common_results\SuccessTest" classname="ParaTest.Tests.fixtures.common_results.SuccessTest" assertions="1" time="1.234567"/>
   </testsuite>
diff --git a/test/fixtures/common_results/junit/WarningTest.xml b/test/fixtures/common_results/junit/WarningTest.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<testsuites name="PHPUnit tests">
+<testsuites>
   <testsuite name="ParaTest\Tests\fixtures\common_results\WarningTest" file="./test/fixtures/common_results/WarningTest.php" tests="1" assertions="1" errors="0" failures="0" skipped="0" time="1.234567">
     <testcase name="testWarning" file="./test/fixtures/common_results/WarningTest.php" line="16" class="ParaTest\Tests\fixtures\common_results\WarningTest" classname="ParaTest.Tests.fixtures.common_results.WarningTest" assertions="1" time="1.234567"/>
   </testsuite>
diff --git a/test/fixtures/github/GH997/worker_tmp_junit.xml b/test/fixtures/github/GH997/worker_tmp_junit.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <testsuites>
-    <testsuite name="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" file="test/fixtures/github/GH997/SuccessfulTests.php" tests="1" assertions="1" errors="0" failures="0" skipped="0" time="0.003250">
-        <testcase name="testSuccessOne" file="test/fixtures/github/GH997/SuccessfulTests.php" line="12" class="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" classname="ParaTest.Tests.fixtures.github.GH997.SuccessfulTests" assertions="1" time="0.003250"/>
+    <testsuite name="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" file="test/fixtures/github/GH997/SuccessfulTests.php" tests="1" assertions="1" errors="0" failures="0" skipped="0" time="1.234567">
+        <testcase name="testSuccessOne" file="test/fixtures/github/GH997/SuccessfulTests.php" line="12" class="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" classname="ParaTest.Tests.fixtures.github.GH997.SuccessfulTests" assertions="1" time="1.234567"/>
     </testsuite>
-    <testsuite name="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" file="test/fixtures/github/GH997/SuccessfulTests.php" tests="1" assertions="1" errors="0" failures="0" skipped="0" time="0.001141">
-        <testcase name="testSuccessTwo" file="test/fixtures/github/GH997/SuccessfulTests.php" line="17" class="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" classname="ParaTest.Tests.fixtures.github.GH997.SuccessfulTests" assertions="1" time="0.001141"/>
+    <testsuite name="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" file="test/fixtures/github/GH997/SuccessfulTests.php" tests="1" assertions="1" errors="0" failures="0" skipped="0" time="1.234567">
+        <testcase name="testSuccessTwo" file="test/fixtures/github/GH997/SuccessfulTests.php" line="17" class="ParaTest\Tests\fixtures\github\GH997\SuccessfulTests" classname="ParaTest.Tests.fixtures.github.GH997.SuccessfulTests" assertions="1" time="1.234567"/>
     </testsuite>
 </testsuites>
diff --git a/test/fixtures/special_chars/data-provider-with-special-chars.xml b/test/fixtures/special_chars/data-provider-with-special-chars.xml

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`	`/** @internal */`
`24`	`24`	`final readonly class Writer`
`25`	`25`	`{`
`26`		`- private const TESTSUITES_NAME = 'PHPUnit tests';`
`27`	`26`	`private DOMDocument $document;`
`28`	`27`
`29`	`28`	`public function __construct()`
`@@ -48,7 +47,6 @@ private function getXml(TestSuite $testSuite): string`
`48`	`47`	`{`
`49`	`48`	`$xmlTestsuites = $this->document->createElement('testsuites');`
`50`	`49`	`$xmlTestsuites->appendChild($this->createSuiteNode($testSuite));`
`51`		`- $xmlTestsuites->setAttribute('name', self::TESTSUITES_NAME);`
`52`	`50`	`$this->document->appendChild($xmlTestsuites);`
`53`	`51`
`54`	`52`	`$xml = $this->document->saveXML();`
`@@ -60,7 +58,7 @@ private function getXml(TestSuite $testSuite): string`
`60`	`58`	`private function createSuiteNode(TestSuite $parentSuite): DOMElement`
`61`	`59`	`{`
`62`	`60`	`$suiteNode = $this->document->createElement('testsuite');`
`63`		`- $suiteNode->setAttribute('name', $parentSuite->name !== self::TESTSUITES_NAME ? $parentSuite->name : '');`
	`61`	`+ $suiteNode->setAttribute('name', $parentSuite->name);`
`64`	`62`	`if ($parentSuite->file !== '') {`
`65`	`63`	`$suiteNode->setAttribute('file', $parentSuite->file);`
`66`	`64`	`}`