Skip to content

Return an empty TestSuite if mainSuite is null #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caherrera wants to merge 2 commits into
base: 6.x
Choose a base branch
from
+5 −3
Open

Return an empty TestSuite if mainSuite is null #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69154f9
Return an empty TestSuite if mainSuite is null
caherrera Oct 17, 2025
02e8e56
Fix indentation of docblock comments in ExecutableTest.php
caherrera Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Logging/LogInterpreter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ public function mergeReaders(): TestSuite
$this->mergeSuites($mainSuite, $otherSuite);
}

assert($mainSuite !== null);
if ($mainSuite === null) {
return new TestSuite('', 0, 0, 0, 0, 0, 0, 0, 0.0, '', [], []);
}

return $mainSuite;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Runners/PHPUnit/ExecutableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ private function unlinkTempFile(?string &$tempName): void
$tempName = null;
}

/**
/**
* Returns the path to this test's JUnit temp file.
* If the temp file does not exist, it will be
* created.
Expand All @@ -121,7 +121,7 @@ final public function deleteTempFiles(): void
$this->unlinkTempFile($this->coverageFileName);
}

/**
/**
* Return the last process command.
*/
final public function getLastCommand(): string
Expand Down
Loading