Skip to content

Commit e4b312d

Browse files
authored
Merge pull request #137 from parca-dev/cleanup
cleanup
2 parents bf5fa71 + 3b8cb13 commit e4b312d

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ support/golbls_1_24.test: ./interpreter/golabels/test/main.go
141141
support/golbls_cgo.test: ./interpreter/golabels/test/main-cgo.go
142142
CGO_ENABLED=1 GOTOOLCHAIN=go1.24.1 go build -ldflags '-extldflags "-static"' -tags $(GO_TAGS),usecgo -o $@ $<
143143

144-
integration-test-binaries: generate ebpf support/golbls_1_23.test support/golbls_1_24.test support/golbls_cgo.test
144+
integration-test-binaries: generate ebpf rust-components support/golbls_1_23.test support/golbls_1_24.test support/golbls_cgo.test
145145
$(foreach test_name, $(TEST_INTEGRATION_BINARY_DIRS), \
146146
(go test -ldflags='-extldflags=-static' -trimpath -c \
147147
-tags $(GO_TAGS),static_build,integration \

processmanager/manager.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -221,19 +221,11 @@ func (pm *ProcessManager) symbolizeFrame(frame int, trace *host.Trace, frames *l
221221
func (pm *ProcessManager) ConvertTrace(trace *host.Trace) (newTrace *libpf.Trace, err error) {
222222
traceLen := len(trace.Frames)
223223
kernelFramesLen := len(trace.KernelFrames)
224-
log.Debugf("ConvertTrace: traceLen=%d, kernelFramesLen=%d", traceLen, kernelFramesLen)
225224

226225
newTrace = &libpf.Trace{
227226
Frames: make(libpf.Frames, kernelFramesLen, kernelFramesLen+traceLen),
228227
CustomLabels: trace.CustomLabels,
229228
}
230-
231-
// Debug kernel frames
232-
for i, kf := range trace.KernelFrames {
233-
frame := kf.Value()
234-
log.Debugf("ConvertTrace: KernelFrame[%d] type=%d fileID=%x", i, frame.Type, frame.FileID)
235-
}
236-
237229
copy(newTrace.Frames, trace.KernelFrames)
238230

239231
for i := range traceLen {
@@ -314,14 +306,6 @@ func (pm *ProcessManager) ConvertTrace(trace *host.Trace) (newTrace *libpf.Trace
314306
}
315307
}
316308
}
317-
318-
// Debug final trace before hashing
319-
log.Debugf("ConvertTrace: Final trace has %d frames", len(newTrace.Frames))
320-
for i, frameHandle := range newTrace.Frames {
321-
frame := frameHandle.Value()
322-
log.Debugf("ConvertTrace: Final Frame[%d] type=%d fileID=%x", i, frame.Type, frame.FileID)
323-
}
324-
325309
newTrace.Hash = traceutil.HashTrace(newTrace)
326310
return newTrace, nil
327311
}

tracer/tracer_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4+
// Package tracer contains functionality for populating tracers.
45
package tracer // import "go.opentelemetry.io/ebpf-profiler/tracer"
56

67
import (

0 commit comments

Comments
 (0)