Fix docker socket issue (#595)

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

Author: kakkoyun

deploy/dev.jsonnet

@@ -26,7 +26,7 @@ function(serverVersion='v0.4.2')
     insecure: true,
     insecureSkipVerify: true,
     //    debugInfoDisable: true,
-    socketPath: '/run/docker.sock',
+    //    socketPath: '/run/docker.sock',
     //    podLabelSelector: 'app.kubernetes.io/name=parca',
   });
 

pkg/containerutils/containerd/containerd.go

@@ -84,7 +84,7 @@ func (c *Client) PIDFromContainerID(containerID string) (int, error) {
 
 	status, err := c.client.ContainerStatus(context.Background(), request)
 	if err != nil {
-		return -1, err
+		return -1, fmt.Errorf("failed to get container status, request: %v: %w", request, err)
 	}
 
 	info, ok := status.Info["info"]

pkg/containerutils/crio/crio.go

@@ -90,7 +90,7 @@ func (c *Client) PIDFromContainerID(containerID string) (int, error) {
 
 	status, err := c.client.ContainerStatus(context.Background(), request)
 	if err != nil {
-		return -1, err
+		return -1, fmt.Errorf("failed to get container status, request: %v: %w", request, err)
 	}
 
 	infoStr, ok := status.Info["info"]

pkg/containerutils/docker/docker.go

@@ -24,7 +24,7 @@ import (
 )
 
 const (
-	DefaultSocketPath = "/var/run/docker.sock"
+	DefaultSocketPath = "/run/docker.sock"
 	DefaultTimeout    = 2 * time.Second
 )
 
@@ -33,7 +33,13 @@ type Client struct {
 }
 
 func NewDockerClient(path string) (*Client, error) {
+	host := path
+	if protoAddrParts := strings.SplitN(host, "://", 2); len(protoAddrParts) == 1 {
+		// The default protocol is unix sockets (tcp and http are also valid).
+		host = "unix://" + host
+	}
 	cli, err := client.NewClientWithOpts(
+		client.WithHost(host),
 		client.WithAPIVersionNegotiation(),
 		client.WithDialContext(func(ctx context.Context, network, addr string) (net.Conn, error) {
 			return net.DialTimeout("unix", path, DefaultTimeout)
@@ -65,7 +71,7 @@ func (c *Client) PIDFromContainerID(containerID string) (int, error) {
 
 	containerJSON, err := c.client.ContainerInspect(context.Background(), containerID)
 	if err != nil {
-		return -1, err
+		return -1, fmt.Errorf("failed to get container status, container id: %s: %w", containerID, err)
 	}
 
 	if containerJSON.State == nil {

pkg/k8s/k8s.go

@@ -109,6 +109,9 @@ func newCRIClient(logger log.Logger, node *v1.Node, socketPath string) (containe
 		if socketPath == "" {
 			socketPath = docker.DefaultSocketPath
 		}
+		if _, err := os.Stat(socketPath); err != nil {
+			return nil, fmt.Errorf("docker socket path is not reachable: %w", err)
+		}
 		return docker.NewDockerClient(socketPath)
 	case "containerd":
 		if socketPath == "" {
@@ -119,11 +122,17 @@ func newCRIClient(logger log.Logger, node *v1.Node, socketPath string) (containe
 				socketPath = containerd.DefaultK3SSocketPath
 			}
 		}
+		if _, err := os.Stat(socketPath); err != nil {
+			return nil, fmt.Errorf("containerd socket path is not reachable: %w", err)
+		}
 		return containerd.NewContainerdClient(socketPath)
 	case "cri-o":
 		if socketPath == "" {
 			socketPath = crio.DefaultSocketPath
 		}
+		if _, err := os.Stat(socketPath); err != nil {
+			return nil, fmt.Errorf("CRI-o socket path is not reachable: %w", err)
+		}
 		return crio.NewCrioClient(logger, socketPath)
 	default:
 		return nil, fmt.Errorf("unknown '%s' cri", criType)