Skip to content

Commit 66c5021

Browse files
committed
Address review comments
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
1 parent eca5382 commit 66c5021

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Flags:
116116
--debuginfo-upload-timeout-duration=2m
117117
The timeout duration to cancel upload
118118
requests.
119-
--symbolizer-disable-jit Disable JIT symbolization.
119+
--symbolizer-jit-disable Disable JIT symbolization.
120120
--dwarf-unwinding-disable Do not unwind using .eh_frame information.
121121
--dwarf-unwinding-use-polling
122122
Poll procfs to generate the unwind

cmd/parca-agent/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ type FlagsDebuginfo struct {
161161

162162
// FlagsSymbolizer contains flags to configure symbolization.
163163
type FlagsSymbolizer struct {
164-
DisableJIT bool `kong:"help='Disable JIT symbolization.'"`
164+
JITDisable bool `kong:"help='Disable JIT symbolization.'"`
165165
}
166166

167167
// FlagsDWARFUnwinding contains flags to configure DWARF unwinding.
@@ -479,7 +479,7 @@ func run(logger log.Logger, reg *prometheus.Registry, flags flags) error {
479479
perf.NewCache(logger),
480480
ksym.NewKsymCache(logger, reg),
481481
vdsoCache,
482-
flags.Symbolizer.DisableJIT,
482+
flags.Symbolizer.JITDisable,
483483
),
484484
process.NewMappingFileCache(logger),
485485
objectfile.NewCache(20, flags.Profiling.Duration),

0 commit comments

Comments
 (0)