Skip to content

Commit cf86edd

Browse files
authored
Improve oomprof logging (#3086)
* Improve oomprof logging * Potential fix
1 parent 8af15e2 commit cf86edd

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ require (
2020
github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus v1.0.1
2121
github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.3.1
2222
github.com/klauspost/compress v1.18.0
23-
github.com/parca-dev/oomprof v0.1.5-0.20250811212952-b45abb82a5fd
23+
github.com/parca-dev/oomprof v0.1.5-0.20250812185216-e44e6c5d4315
2424
github.com/prometheus/client_golang v1.22.0
2525
github.com/prometheus/common v0.63.0
2626
github.com/prometheus/prometheus v0.303.0
@@ -163,4 +163,4 @@ require (
163163
sigs.k8s.io/yaml v1.4.0 // indirect
164164
)
165165

166-
replace go.opentelemetry.io/ebpf-profiler => github.com/parca-dev/opentelemetry-ebpf-profiler v0.0.0-20250811214617-bb37a8a7e096
166+
replace go.opentelemetry.io/ebpf-profiler => github.com/parca-dev/opentelemetry-ebpf-profiler v0.0.0-20250812190145-028272f9477c

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,10 +257,10 @@ github.com/opencontainers/runtime-spec v1.2.1 h1:S4k4ryNgEpxW1dzyqffOmhI1BHYcjzU
257257
github.com/opencontainers/runtime-spec v1.2.1/go.mod h1:jwyrGlmzljRJv/Fgzds9SsS/C5hL+LL3ko9hs6T5lQ0=
258258
github.com/opencontainers/selinux v1.12.0 h1:6n5JV4Cf+4y0KNXW48TLj5DwfXpvWlxXplUkdTrmPb8=
259259
github.com/opencontainers/selinux v1.12.0/go.mod h1:BTPX+bjVbWGXw7ZZWUbdENt8w0htPSrlgOOysQaU62U=
260-
github.com/parca-dev/oomprof v0.1.5-0.20250811212952-b45abb82a5fd h1:uHo+bScocZbyqOnH7FeynMvaK/Exk+QQGFn5dfI4TRU=
261-
github.com/parca-dev/oomprof v0.1.5-0.20250811212952-b45abb82a5fd/go.mod h1:+vw0+rZYq/rTVouF6G+/+Uol758EOkUINi8/8RXPvX0=
262-
github.com/parca-dev/opentelemetry-ebpf-profiler v0.0.0-20250811214617-bb37a8a7e096 h1:WbBrsMXvRj8JWOUL4/qe1WJkmsFWqDxC1ld558K/d0Q=
263-
github.com/parca-dev/opentelemetry-ebpf-profiler v0.0.0-20250811214617-bb37a8a7e096/go.mod h1:WxDFlcvFLFkT8bfoSGBDtVombgqLEMzVYb3DVNDkOUo=
260+
github.com/parca-dev/oomprof v0.1.5-0.20250812185216-e44e6c5d4315 h1:pEFFbT0kszs0NFjKevggSQhyd0pjfA8GgUvm7ApBmos=
261+
github.com/parca-dev/oomprof v0.1.5-0.20250812185216-e44e6c5d4315/go.mod h1:+vw0+rZYq/rTVouF6G+/+Uol758EOkUINi8/8RXPvX0=
262+
github.com/parca-dev/opentelemetry-ebpf-profiler v0.0.0-20250812190145-028272f9477c h1:QNu3O0YrS3mzV/mBYN+DPdpfNKRRkb+xZ0CnZyhXlF4=
263+
github.com/parca-dev/opentelemetry-ebpf-profiler v0.0.0-20250812190145-028272f9477c/go.mod h1:p7Q12UBTjk7JN5NP2/X/VmZ178W8pCRkJtPL/BRzOTU=
264264
github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58 h1:onHthvaw9LFnH4t2DcNVpwGmV9E1BkGknEliJkfwQj0=
265265
github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58/go.mod h1:DXv8WO4yhMYhSNPKjeNKa5WY9YCIEBRbNzFFPJbWO6Y=
266266
github.com/pierrec/lz4/v4 v4.1.22 h1:cKFw6uJDK+/gfw5BcDL0JL5aBsAFdsIT18eRtLj7VIU=

reporter/parca_reporter.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,9 @@ func (r *ParcaReporter) ReportTraceEvent(trace *libpf.Trace,
275275
writeSample(meta.OffTime, time.Second.Nanoseconds(), 1e9/int64(r.samplesPerSecond), "parca_agent", "wallclock", "nanoseconds", "samples", "count")
276276
r.sampleWriter.Temporality.AppendString("delta")
277277
case support.TraceOriginMemory:
278+
// This shouldn't happen too much so an info log is fine, revisit when we do continuous memory profiling.
279+
log.Infof("Received memory trace event for TID %d, PID %d, comm %s", meta.TID, meta.PID, meta.Comm)
280+
// TODO: this isn't necessarily correct and should be extracted from the Go process somehow.
278281
memPeriod := int64(512 * 1024) // 512 KiB
279282
// Write 4 memory samples
280283
// 1. inuse_objects (Allocs - Frees)

0 commit comments

Comments
 (0)