reporter: Fix disabling debuginfo uploads

brancz · brancz · commit e3e0fc2ea2b6 · 2025-01-21T21:23:11.000+01:00
diff --git a/reporter/parca_reporter.go b/reporter/parca_reporter.go
@@ -256,7 +256,9 @@ func (r *ParcaReporter) ExecutableMetadata(args *reporter.ExecutableMetadataArgs
 	}
 
 	// Always attempt to upload, the uploader is responsible for deduplication.
-	r.uploader.Upload(context.TODO(), args.FileID, args.GnuBuildID, args.Open)
+	if !r.disableSymbolUpload {
+		r.uploader.Upload(context.TODO(), args.FileID, args.GnuBuildID, args.Open)
+	}
 
 	if _, exists := r.executables.Get(args.FileID); exists {
 		return

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,9 @@ func (r ParcaReporter) ExecutableMetadata(args reporter.ExecutableMetadataArgs`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`// Always attempt to upload, the uploader is responsible for deduplication.`
`259`		`- r.uploader.Upload(context.TODO(), args.FileID, args.GnuBuildID, args.Open)`
	`259`	`+ if !r.disableSymbolUpload {`
	`260`	`+ r.uploader.Upload(context.TODO(), args.FileID, args.GnuBuildID, args.Open)`
	`261`	`+ }`
`260`	`262`
`261`	`263`	`if _, exists := r.executables.Get(args.FileID); exists {`
`262`	`264`	`return`