Skip to content

Commit ed2a75e

Browse files
authored
Merge pull request #1523 from parca-dev/fix-dbg-struct
cmd/parca-agent: Fix debuginfo flags struct
2 parents 072ddc2 + 02891e3 commit ed2a75e

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,8 @@ Flags:
100100
Leave this empty to use the default value of
101101
10s.
102102
--debuginfo-directories=/usr/lib/debug,...
103-
Ordered list of local directories to
104-
search for debuginfo files. Defaults to
105-
/usr/lib/debug.
103+
Ordered list of local directories to search
104+
for debuginfo files.
106105
--debuginfo-temp-dir="/tmp"
107106
The local directory path to store the interim
108107
debuginfo files.

cmd/parca-agent/main.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,11 @@ type FlagsRemoteStore struct {
152152

153153
// FlagsDebuginfo contains flags to configure debuginfo.
154154
type FlagsDebuginfo struct {
155-
Directories []string `default:"/usr/lib/debug" help:"Ordered list of local directories to search for debuginfo files. Defaults to /usr/lib/debug."`
156-
TempDir string `default:"/tmp" help:"The local directory path to store the interim debuginfo files."`
157-
Strip bool `default:"true" help:"Only upload information needed for symbolization. If false the exact binary the agent sees will be uploaded unmodified."`
158-
UploadCacheDuration time.Duration `default:"5m" help:"The duration to cache debuginfo upload exists checks for."`
159-
UploadTimeoutDuration time.Duration `default:"2m" help:"The timeout duration to cancel upload requests."`
155+
Directories []string `kong:"help='Ordered list of local directories to search for debuginfo files.',default='/usr/lib/debug'"`
156+
TempDir string `kong:"help='The local directory path to store the interim debuginfo files.',default='/tmp'"`
157+
Strip bool `kong:"help='Only upload information needed for symbolization. If false the exact binary the agent sees will be uploaded unmodified.',default='true'"`
158+
UploadCacheDuration time.Duration `kong:"help='The duration to cache debuginfo upload exists checks for.',default='5m'"`
159+
UploadTimeoutDuration time.Duration `kong:"help='The timeout duration to cancel upload requests.',default='2m'"`
160160
}
161161

162162
// FlagsSymbolizer contains flags to configure symbolization.

0 commit comments

Comments
 (0)